| Message ID | 1457860062-5514-3-git-send-email-wxt@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 3/13/2016 12:07 PM, Caesar Wang wrote: > This patch adds the following property for arc_emac. > > 1) reset-gpios: > The phy reset-gpio is an optional property for arc emac device tree boot. > Change the binding document to match the driver code. > > 2) phy-reset-duration: > Different boards may require different phy reset duration. Add property > phy-reset-duration for device tree probe, so that the boards that need > a longer reset duration can specify it in their device tree. > > Anyway, we can add the above property for arc emac. > > Signed-off-by: Caesar Wang <wxt@rock-chips.com> > --- > > Changes in v2: None Not true -- you renamed the reset prop. > Documentation/devicetree/bindings/net/arc_emac.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/arc_emac.txt b/Documentation/devicetree/bindings/net/arc_emac.txt > index a1d71eb..8e84b52 100644 > --- a/Documentation/devicetree/bindings/net/arc_emac.txt > +++ b/Documentation/devicetree/bindings/net/arc_emac.txt > @@ -7,6 +7,13 @@ Required properties: > - max-speed: see ethernet.txt file in the same directory. > - phy: see ethernet.txt file in the same directory. > > +Optional properties: > +- reset-gpios : Should specify the gpio for phy reset Please leave the old name, "phy-reset-gpios" was surely better. [...] MBR, Sergei
diff --git a/Documentation/devicetree/bindings/net/arc_emac.txt b/Documentation/devicetree/bindings/net/arc_emac.txt index a1d71eb..8e84b52 100644 --- a/Documentation/devicetree/bindings/net/arc_emac.txt +++ b/Documentation/devicetree/bindings/net/arc_emac.txt @@ -7,6 +7,13 @@ Required properties: - max-speed: see ethernet.txt file in the same directory. - phy: see ethernet.txt file in the same directory. +Optional properties: +- reset-gpios : Should specify the gpio for phy reset +- phy-reset-duration : Reset duration in milliseconds. Should present + only if property "reset-gpios" is available. Missing the property + will have the duration be 1 millisecond. Numbers greater than 1000 are + invalid and 1 millisecond will be used instead. + Clock handling: The clock frequency is needed to calculate and set polling period of EMAC. It must be provided by one of:
This patch adds the following property for arc_emac. 1) reset-gpios: The phy reset-gpio is an optional property for arc emac device tree boot. Change the binding document to match the driver code. 2) phy-reset-duration: Different boards may require different phy reset duration. Add property phy-reset-duration for device tree probe, so that the boards that need a longer reset duration can specify it in their device tree. Anyway, we can add the above property for arc emac. Signed-off-by: Caesar Wang <wxt@rock-chips.com> --- Changes in v2: None Documentation/devicetree/bindings/net/arc_emac.txt | 7 +++++++ 1 file changed, 7 insertions(+)