| Message ID | 1455368071-15198-1-git-send-email-steved@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/13/2016 07:54 AM, Steve Dickson wrote: > xlog_err() never returns. Change the xlog_err(), > when invalid arguments are use, to xlog_warn() > so the second xlog_warn, displaying the usage, > will be called. > > Signed-off-by: Steve Dickson <steved@redhat.com> Committed... steved. > --- > utils/nfsidmap/nfsidmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/utils/nfsidmap/nfsidmap.c b/utils/nfsidmap/nfsidmap.c > index d980c68..2abefe9 100644 > --- a/utils/nfsidmap/nfsidmap.c > +++ b/utils/nfsidmap/nfsidmap.c > @@ -430,7 +430,7 @@ int main(int argc, char **argv) > > xlog_stderr(verbose); > if ((argc - optind) != 2) { > - xlog_err("Bad arg count. Check /etc/request-key.conf"); > + xlog_warn("Bad arg count. Check /etc/request-key.conf"); > xlog_warn(usage, progname); > return EXIT_FAILURE; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/utils/nfsidmap/nfsidmap.c b/utils/nfsidmap/nfsidmap.c index d980c68..2abefe9 100644 --- a/utils/nfsidmap/nfsidmap.c +++ b/utils/nfsidmap/nfsidmap.c @@ -430,7 +430,7 @@ int main(int argc, char **argv) xlog_stderr(verbose); if ((argc - optind) != 2) { - xlog_err("Bad arg count. Check /etc/request-key.conf"); + xlog_warn("Bad arg count. Check /etc/request-key.conf"); xlog_warn(usage, progname); return EXIT_FAILURE; }
xlog_err() never returns. Change the xlog_err(), when invalid arguments are use, to xlog_warn() so the second xlog_warn, displaying the usage, will be called. Signed-off-by: Steve Dickson <steved@redhat.com> --- utils/nfsidmap/nfsidmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)