| Message ID | 1458287002-21842-1-git-send-email-yegorslists@googlemail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 18, 2016 at 08:43:22AM +0100, yegorslists@googlemail.com wrote: > From: Yegor Yefremov <yegorslists@googlemail.com> > > In Baltos iR5221 cpsw_emac0 is connected directly to the switch IC and > hence needs to be configured as "fixed-link". > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> One nit pick below, but otherwise: Reviewed-by: Andrew Lunn <andrew@lunn.ch> > --- > arch/arm/boot/dts/am335x-baltos-ir5221.dts | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am335x-baltos-ir5221.dts b/arch/arm/boot/dts/am335x-baltos-ir5221.dts > index ded1eb6..8a0cdda 100644 > --- a/arch/arm/boot/dts/am335x-baltos-ir5221.dts > +++ b/arch/arm/boot/dts/am335x-baltos-ir5221.dts > @@ -469,9 +469,12 @@ > }; > > &cpsw_emac0 { > - phy_id = <&davinci_mdio>, <0>; > phy-mode = "rmii"; > dual_emac_res_vlan = <1>; > + fixed-link { > + speed = <100>; > + full-duplex; > + }; Looks like there is a tab/space problem here. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Andrew Lunn <andrew@lunn.ch> [160318 06:11]: > On Fri, Mar 18, 2016 at 08:43:22AM +0100, yegorslists@googlemail.com wrote: > > From: Yegor Yefremov <yegorslists@googlemail.com> > > > > In Baltos iR5221 cpsw_emac0 is connected directly to the switch IC and > > hence needs to be configured as "fixed-link". > > > > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com> > > One nit pick below, but otherwise: > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > > > --- > > arch/arm/boot/dts/am335x-baltos-ir5221.dts | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/am335x-baltos-ir5221.dts b/arch/arm/boot/dts/am335x-baltos-ir5221.dts > > index ded1eb6..8a0cdda 100644 > > --- a/arch/arm/boot/dts/am335x-baltos-ir5221.dts > > +++ b/arch/arm/boot/dts/am335x-baltos-ir5221.dts > > @@ -469,9 +469,12 @@ > > }; > > > > &cpsw_emac0 { > > - phy_id = <&davinci_mdio>, <0>; > > phy-mode = "rmii"; > > dual_emac_res_vlan = <1>; > > + fixed-link { > > + speed = <100>; > > + full-duplex; > > + }; > > Looks like there is a tab/space problem here. Tabified and applying into omap-for-v4.6/fixes thanks. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/am335x-baltos-ir5221.dts b/arch/arm/boot/dts/am335x-baltos-ir5221.dts index ded1eb6..8a0cdda 100644 --- a/arch/arm/boot/dts/am335x-baltos-ir5221.dts +++ b/arch/arm/boot/dts/am335x-baltos-ir5221.dts @@ -469,9 +469,12 @@ }; &cpsw_emac0 { - phy_id = <&davinci_mdio>, <0>; phy-mode = "rmii"; dual_emac_res_vlan = <1>; + fixed-link { + speed = <100>; + full-duplex; + }; }; &cpsw_emac1 {