diff mbox

ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts

Message ID 1458137962-27714-1-git-send-email-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hans de Goede March 16, 2016, 2:19 p.m. UTC
u-boot uses the kernel as the canonical source for its sunxi dts files
and u-boot needs these.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 arch/arm/boot/dts/sun6i-a31s-primo81.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Chen-Yu Tsai March 17, 2016, 6:28 a.m. UTC | #1
On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> u-boot uses the kernel as the canonical source for its sunxi dts files
> and u-boot needs these.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Chen-Yu Tsai <wens@csie.org>
Maxime Ripard March 18, 2016, 5:48 p.m. UTC | #2
On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
> On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > u-boot uses the kernel as the canonical source for its sunxi dts files
> > and u-boot needs these.
> >
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Acked-by: Chen-Yu Tsai <wens@csie.org>

Queued, thanks!
Maxime
Hans de Goede March 19, 2016, 9:13 a.m. UTC | #3
Hi,

On 18-03-16 18:48, Maxime Ripard wrote:
> On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
>> On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>> u-boot uses the kernel as the canonical source for its sunxi dts files
>>> and u-boot needs these.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> Queued, thanks!

I just got an of-list mail from Karsten Merker that you nacked the addition
if this during the initial submission, because there are no accessible uart
test pads on this tablet.

In that case the proper fix would be to change the u-boot defconfig to have:

# CONFIG_REQUIRE_SERIAL_CONSOLE is not set

Which will stop u-boot from panicking (with nowhere to print the panic msg)
when it has no stdout-path.

Can you unqueue this one until we've figured out what the best fix is ?

Thanks & Regards,

Hans
Maxime Ripard March 21, 2016, 7:50 a.m. UTC | #4
On Sat, Mar 19, 2016 at 10:13:47AM +0100, Hans de Goede wrote:
> Hi,
> 
> On 18-03-16 18:48, Maxime Ripard wrote:
> >On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote:
> >>On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> >>>u-boot uses the kernel as the canonical source for its sunxi dts files
> >>>and u-boot needs these.
> >>>
> >>>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>
> >>Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
> >Queued, thanks!
> 
> I just got an of-list mail from Karsten Merker that you nacked the addition
> if this during the initial submission, because there are no accessible uart
> test pads on this tablet.
> 
> In that case the proper fix would be to change the u-boot defconfig to have:
> 
> # CONFIG_REQUIRE_SERIAL_CONSOLE is not set
> 
> Which will stop u-boot from panicking (with nowhere to print the panic msg)
> when it has no stdout-path.
> 
> Can you unqueue this one until we've figured out what the best fix is ?

Done, thanks!
Maxime
diff mbox

Patch

diff --git a/arch/arm/boot/dts/sun6i-a31s-primo81.dts b/arch/arm/boot/dts/sun6i-a31s-primo81.dts
index 68b479b..379746a 100644
--- a/arch/arm/boot/dts/sun6i-a31s-primo81.dts
+++ b/arch/arm/boot/dts/sun6i-a31s-primo81.dts
@@ -53,6 +53,14 @@ 
 / {
 	model = "MSI Primo81 tablet";
 	compatible = "msi,primo81", "allwinner,sun6i-a31s";
+
+	aliases {
+		serial0 = &uart0;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
 };
 
 &cpu0 {