| Message ID | 87shz7ihcg.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
Hi Morimoto-san, On Thu, Mar 31, 2016 at 3:14 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > DRM_RCAR_VSP requests VIDEO_RENESAS_VSP1, and VIDEO_RENESAS_VSP1 requests > VIDEO_RENESAS_FCP. But VIDEO_RENESAS_FCP is not set on defconfig. > This patch adds it. Otherwise kernel goes to Oops. IMHO either the driver should handle this case (i.e. not oops), or the logic should be expressed in Kconfig. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert > > DRM_RCAR_VSP requests VIDEO_RENESAS_VSP1, and VIDEO_RENESAS_VSP1 requests > > VIDEO_RENESAS_FCP. But VIDEO_RENESAS_FCP is not set on defconfig. > > This patch adds it. Otherwise kernel goes to Oops. > > IMHO either the driver should handle this case (i.e. not oops), or the > logic should > be expressed in Kconfig. Yeah, I think so. I'm not sure detail, but this is because renesas-driver is including local drm patches (?). It is not yet formal on upstream, thus, this patch is not formal style :)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f78360c..4101d78 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -183,6 +183,7 @@ CONFIG_V4L_PLATFORM_DRIVERS=y CONFIG_SOC_CAMERA=y CONFIG_SOC_CAMERA_PLATFORM=y CONFIG_V4L_MEM2MEM_DRIVERS=y +CONFIG_VIDEO_RENESAS_FCP=y CONFIG_VIDEO_RENESAS_VSP1=y CONFIG_DRM=y CONFIG_DRM_RCAR_DU=y
DRM_RCAR_VSP requests VIDEO_RENESAS_VSP1, and VIDEO_RENESAS_VSP1 requests VIDEO_RENESAS_FCP. But VIDEO_RENESAS_FCP is not set on defconfig. This patch adds it. Otherwise kernel goes to Oops. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- Geert: This patch is for renesas-drivers-2016-03-29-v4.6-rc1 arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)