| Message ID | 1459290646-3592-2-git-send-email-manabian@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Joachim, On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote: > Add unit name to nvic to remove the following warning: > Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg > or ranges property, but no unit name > > Also correct the node name to 'interrupt-controller' while changing the > line. > > Signed-off-by: Joachim Eastwood <manabian@gmail.com> Looks right, Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On 4 April 2016 at 08:05, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Hello Joachim, > > On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote: >> Add unit name to nvic to remove the following warning: >> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg >> or ranges property, but no unit name >> >> Also correct the node name to 'interrupt-controller' while changing the >> line. >> >> Signed-off-by: Joachim Eastwood <manabian@gmail.com> > Looks right, > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks, Uwe. Unless any of the other Cortex-M platform maintainers (added more CCs) has any objections I'll take this through the lpc18xx tree. I will send a pull request to arm-soc with this soon. regards, Joachim Eastwood
On 2016-04-03 23:42, Joachim Eastwood wrote: > On 4 April 2016 at 08:05, Uwe Kleine-König > <u.kleine-koenig@pengutronix.de> wrote: >> Hello Joachim, >> >> On Wed, Mar 30, 2016 at 12:30:40AM +0200, Joachim Eastwood wrote: >>> Add unit name to nvic to remove the following warning: >>> Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg >>> or ranges property, but no unit name >>> >>> Also correct the node name to 'interrupt-controller' while changing the >>> line. >>> >>> Signed-off-by: Joachim Eastwood <manabian@gmail.com> >> Looks right, >> >> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Thanks, Uwe. > > > Unless any of the other Cortex-M platform maintainers (added more CCs) > has any objections I'll take this through the lpc18xx tree. I will > send a pull request to arm-soc with this soon. Your patch looks right, I agree we should merge yours. Acked-by: Stefan Agner <stefan@agner.ch> -- Stefan
Hello Joachim, On Mon, Apr 04, 2016 at 08:42:48AM +0200, Joachim Eastwood wrote: > Unless any of the other Cortex-M platform maintainers (added more CCs) > has any objections I'll take this through the lpc18xx tree. I will > send a pull request to arm-soc with this soon. that is fine for me. Best regards Uwe
diff --git a/arch/arm/boot/dts/armv7-m.dtsi b/arch/arm/boot/dts/armv7-m.dtsi index b1ad7cf..16331aa 100644 --- a/arch/arm/boot/dts/armv7-m.dtsi +++ b/arch/arm/boot/dts/armv7-m.dtsi @@ -1,7 +1,7 @@ #include "skeleton.dtsi" / { - nvic: nv-interrupt-controller { + nvic: interrupt-controller@e000e100 { compatible = "arm,armv7m-nvic"; interrupt-controller; #interrupt-cells = <1>;
Add unit name to nvic to remove the following warning: Warning (unit_address_vs_reg): Node /nv-interrupt-controller has a reg or ranges property, but no unit name Also correct the node name to 'interrupt-controller' while changing the line. Signed-off-by: Joachim Eastwood <manabian@gmail.com> --- arch/arm/boot/dts/armv7-m.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)