diff mbox

rtl8139: using CP_TX_OWN for ownership transferring during tx

Message ID 1459479208-10452-1-git-send-email-jasowang@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jason Wang April 1, 2016, 2:53 a.m. UTC 
Through CP_TX_OWN and CP_RX_OWN points to the same bit, we'd better use
CP_TX_OWN for tx descriptor handling.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 hw/net/rtl8139.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jason Wang April 5, 2016, 12:54 a.m. UTC | #1 
On 04/01/2016 10:53 AM, Jason Wang wrote:
> Through CP_TX_OWN and CP_RX_OWN points to the same bit, we'd better use
> CP_TX_OWN for tx descriptor handling.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  hw/net/rtl8139.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
> index fee97bf..1e5ec14 100644
> --- a/hw/net/rtl8139.c
> +++ b/hw/net/rtl8139.c
> @@ -2046,7 +2046,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
>      }
>  
>      /* transfer ownership to target */
> -    txdw0 &= ~CP_RX_OWN;
> +    txdw0 &= ~CP_TX_OWN;
>  
>      /* reset error indicator bits */
>      txdw0 &= ~CP_TX_STATUS_UNF;

Applied to -net.

Thanks
diff mbox

Patch

diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index fee97bf..1e5ec14 100644
--- a/hw/net/rtl8139.c
+++ b/hw/net/rtl8139.c
@@ -2046,7 +2046,7 @@  static int rtl8139_cplus_transmit_one(RTL8139State *s)
     }
 
     /* transfer ownership to target */
-    txdw0 &= ~CP_RX_OWN;
+    txdw0 &= ~CP_TX_OWN;
 
     /* reset error indicator bits */
     txdw0 &= ~CP_TX_STATUS_UNF;