diff mbox

[v2,1/4] hwrng: exynos - Runtime suspend device after init

Message ID 1457914035-26856-1-git-send-email-k.kozlowski@samsung.com (mailing list archive)
State Accepted
Delegated to: Herbert Xu
Headers show

Commit Message

Krzysztof Kozlowski March 14, 2016, 12:07 a.m. UTC 
The driver uses pm_runtime_put_noidle() after initialization so the
device might remain in active state if the core does not read from it
(the read callback contains regular runtime put). The put_noidle() was
chosen probably to avoid unneeded suspend and resume cycle after the
initialization.

However for this purpose autosuspend is enabled so it is safe to runtime
put just after the initialization.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

Changes since v1:
1. None.
---
 drivers/char/hw_random/exynos-rng.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Herbert Xu April 5, 2016, 12:44 p.m. UTC | #1 
On Mon, Mar 14, 2016 at 09:07:12AM +0900, Krzysztof Kozlowski wrote:
> The driver uses pm_runtime_put_noidle() after initialization so the
> device might remain in active state if the core does not read from it
> (the read callback contains regular runtime put). The put_noidle() was
> chosen probably to avoid unneeded suspend and resume cycle after the
> initialization.
> 
> However for this purpose autosuspend is enabled so it is safe to runtime
> put just after the initialization.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

All applied.
diff mbox

Patch

diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c
index ada081232528..d1fd21e99368 100644
--- a/drivers/char/hw_random/exynos-rng.c
+++ b/drivers/char/hw_random/exynos-rng.c
@@ -77,7 +77,8 @@  static int exynos_init(struct hwrng *rng)
 
 	pm_runtime_get_sync(exynos_rng->dev);
 	ret = exynos_rng_configure(exynos_rng);
-	pm_runtime_put_noidle(exynos_rng->dev);
+	pm_runtime_mark_last_busy(exynos_rng->dev);
+	pm_runtime_put_autosuspend(exynos_rng->dev);
 
 	return ret;
 }