diff mbox

tests: ignore test-logging

Message ID 57036822.9070501@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Changlong Xie April 5, 2016, 7:24 a.m. UTC
On 04/05/2016 02:35 PM, Changlong Xie wrote:
> Commit 3514552e added a new test, but did not mark it for
> exclusion in .gitignore.
>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>   tests/.gitignore | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index b7bf13e..898a35f 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -70,5 +70,6 @@ test-xbzrle
>   test-netfilter
>   test-filter-mirror
>   test-filter-redirector
> +test-logging
>   *-test
>   qapi-schema/*.test.*
>
It seems we should keep items in order, so

 From a6d9e3aeaee66941613ebed312ee7a1b0e80bcc3 Mon Sep 17 00:00:00 2001
From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
Date: Thu, 31 Mar 2016 13:52:35 +0800
Subject: [PATCH] tests: ignore test-logging

Commit 3514552e added a new test, but did not mark it for
exclusion in .gitignore.

Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
  tests/.gitignore | 1 +
  1 file changed, 1 insertion(+)

Comments

Eric Blake April 5, 2016, 4:44 p.m. UTC | #1
On 04/05/2016 01:24 AM, Changlong Xie wrote:
> On 04/05/2016 02:35 PM, Changlong Xie wrote:
>> Commit 3514552e added a new test, but did not mark it for
>> exclusion in .gitignore.
>>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> ---
>>   tests/.gitignore | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/.gitignore b/tests/.gitignore
>> index b7bf13e..898a35f 100644
>> --- a/tests/.gitignore
>> +++ b/tests/.gitignore
>> @@ -70,5 +70,6 @@ test-xbzrle
>>   test-netfilter
>>   test-filter-mirror
>>   test-filter-redirector
>> +test-logging
>>   *-test
>>   qapi-schema/*.test.*
>>
> It seems we should keep items in order, so
> 
> From a6d9e3aeaee66941613ebed312ee7a1b0e80bcc3 Mon Sep 17 00:00:00 2001
> From: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> Date: Thu, 31 Mar 2016 13:52:35 +0800
> Subject: [PATCH] tests: ignore test-logging
> 
> Commit 3514552e added a new test, but did not mark it for
> exclusion in .gitignore.

May be easier to resend this as a top-level v2 (or now v3), so that it
is easier for a maintainer to pick up.  But in any case, your v2 is:
Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox

Patch

diff --git a/tests/.gitignore b/tests/.gitignore
index 6479b79..a303aaa 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -39,6 +39,7 @@  test-io-channel-file.txt
  test-io-channel-socket
  test-io-channel-tls
  test-io-task
+test-logging
  test-mul64
  test-opts-visitor
  test-qapi-event.[ch]