Message ID | 1459244924-9840-1-git-send-email-caoj.fnst@cn.fujitsu.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
sorry mjt, I intended to cc qemu-trivial, now I made it:) On 03/29/2016 05:48 PM, Cao jin wrote: > The spec says: "on paragraph (16-byte) boundaries" > > Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> > --- > include/hw/smbios/smbios.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h > index 76ccf70..ba36746 100644 > --- a/include/hw/smbios/smbios.h > +++ b/include/hw/smbios/smbios.h > @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType { > > /* SMBIOS Entry Point > * There are two types of entry points defined in the SMBIOS specification > - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned > + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned > * address between 0xf0000 and 0xfffff. Note that either entry point type > * can be used in a 64-bit target system, except that SMBIOS 2.1 entry point > * only allows the SMBIOS struct table to reside below 4GB address space. >
ping? On 03/29/2016 05:57 PM, Cao jin wrote: > sorry mjt, I intended to cc qemu-trivial, now I made it:) > > On 03/29/2016 05:48 PM, Cao jin wrote: >> The spec says: "on paragraph (16-byte) boundaries" >> >> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> >> --- >> include/hw/smbios/smbios.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h >> index 76ccf70..ba36746 100644 >> --- a/include/hw/smbios/smbios.h >> +++ b/include/hw/smbios/smbios.h >> @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType { >> >> /* SMBIOS Entry Point >> * There are two types of entry points defined in the SMBIOS >> specification >> - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned >> + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned >> * address between 0xf0000 and 0xfffff. Note that either entry point >> type >> * can be used in a 64-bit target system, except that SMBIOS 2.1 >> entry point >> * only allows the SMBIOS struct table to reside below 4GB address >> space. >> >
hi, this is a typo patch, could I get confirmed? For your quick reference: System Management BIOS (SMBIOS) Reference Specification, version 3.0.0. chapter 5.2.1 & 5.2.2 On 04/09/2016 05:13 PM, Cao jin wrote: > ping? > > On 03/29/2016 05:57 PM, Cao jin wrote: >> sorry mjt, I intended to cc qemu-trivial, now I made it:) >> >> On 03/29/2016 05:48 PM, Cao jin wrote: >>> The spec says: "on paragraph (16-byte) boundaries" >>> >>> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> >>> --- >>> include/hw/smbios/smbios.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h >>> index 76ccf70..ba36746 100644 >>> --- a/include/hw/smbios/smbios.h >>> +++ b/include/hw/smbios/smbios.h >>> @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType { >>> >>> /* SMBIOS Entry Point >>> * There are two types of entry points defined in the SMBIOS >>> specification >>> - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned >>> + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned >>> * address between 0xf0000 and 0xfffff. Note that either entry point >>> type >>> * can be used in a 64-bit target system, except that SMBIOS 2.1 >>> entry point >>> * only allows the SMBIOS struct table to reside below 4GB address >>> space. >>> >> >
29.03.2016 12:57, Cao jin wrote: > On 03/29/2016 05:48 PM, Cao jin wrote: >> The spec says: "on paragraph (16-byte) boundaries" (Finally!) applied to -trivial. I'm sorry this took too long. Thanks! /mjt
diff --git a/include/hw/smbios/smbios.h b/include/hw/smbios/smbios.h index 76ccf70..ba36746 100644 --- a/include/hw/smbios/smbios.h +++ b/include/hw/smbios/smbios.h @@ -33,7 +33,7 @@ typedef enum SmbiosEntryPointType { /* SMBIOS Entry Point * There are two types of entry points defined in the SMBIOS specification - * (see below). BIOS must place the entry point(s) at a 16-bit-aligned + * (see below). BIOS must place the entry point(s) at a 16-byte-aligned * address between 0xf0000 and 0xfffff. Note that either entry point type * can be used in a 64-bit target system, except that SMBIOS 2.1 entry point * only allows the SMBIOS struct table to reside below 4GB address space.
The spec says: "on paragraph (16-byte) boundaries" Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com> --- include/hw/smbios/smbios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)