diff mbox

[2/2] ARM: multi_v5_defconfig: Enable recommended options for systemd

Message ID 1458991706-30109-2-git-send-email-jlu@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Lübbe March 26, 2016, 11:28 a.m. UTC
Enable FHANDLE, CGROUPS, BLK_DEV_BSG and DEVTMPFS as recommended by
systemd (which also matches the multi_v7 defconfig). Also enable IPV6,
which defaults to 'y' by now.

Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
 arch/arm/configs/multi_v5_defconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jan Lübbe April 12, 2016, 11:57 a.m. UTC | #1
On Sa, 2016-03-26 at 12:28 +0100, Jan Luebbe wrote:
> Enable FHANDLE, CGROUPS, BLK_DEV_BSG and DEVTMPFS as recommended by
> systemd (which also matches the multi_v7 defconfig). Also enable IPV6,
> which defaults to 'y' by now.
> 
> Signed-off-by: Jan Luebbe <jlu@pengutronix.de>

Shawn, you've already applied 1/2. Do you have any concerns or comments
regarding this one?

Regards,
Jan
Shawn Guo April 12, 2016, 2:26 p.m. UTC | #2
On Tue, Apr 12, 2016 at 01:57:48PM +0200, Jan Lübbe wrote:
> On Sa, 2016-03-26 at 12:28 +0100, Jan Luebbe wrote:
> > Enable FHANDLE, CGROUPS, BLK_DEV_BSG and DEVTMPFS as recommended by
> > systemd (which also matches the multi_v7 defconfig). Also enable IPV6,
> > which defaults to 'y' by now.
> > 
> > Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> 
> Shawn, you've already applied 1/2. Do you have any concerns or comments
> regarding this one?

I thought that Arnd's request and Sascha's ACK only applies to 1/2.
Just applied 2/2 as well.  @Arnd, let me know if I shouldn't.

Shawn
Arnd Bergmann April 18, 2016, 7:28 p.m. UTC | #3
On Tuesday 12 April 2016 22:26:54 Shawn Guo wrote:
> On Tue, Apr 12, 2016 at 01:57:48PM +0200, Jan Lübbe wrote:
> > On Sa, 2016-03-26 at 12:28 +0100, Jan Luebbe wrote:
> > > Enable FHANDLE, CGROUPS, BLK_DEV_BSG and DEVTMPFS as recommended by
> > > systemd (which also matches the multi_v7 defconfig). Also enable IPV6,
> > > which defaults to 'y' by now.
> > > 
> > > Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
> > 
> > Shawn, you've already applied 1/2. Do you have any concerns or comments
> > regarding this one?
> 
> I thought that Arnd's request and Sascha's ACK only applies to 1/2.
> Just applied 2/2 as well.  @Arnd, let me know if I shouldn't.
> 
> 

I'd like to see both get picked up into the same branch if the changes are
for the same platform, sorry if that wasn't clear enough.

I guess in this case you can argue that the actual changes of 2/2 are
not imx specific at all, and I'd be fine with picking them up directly,
but I tend to prefer the defconfig changes to come from one of the subarch
maintainers just so I don't have to watch too carefully for patches
on the mailing list.

	Arnd
diff mbox

Patch

diff --git a/arch/arm/configs/multi_v5_defconfig b/arch/arm/configs/multi_v5_defconfig
index bb8d609..a822dd3 100644
--- a/arch/arm/configs/multi_v5_defconfig
+++ b/arch/arm/configs/multi_v5_defconfig
@@ -1,14 +1,15 @@ 
 CONFIG_SYSVIPC=y
+CONFIG_FHANDLE=y
 CONFIG_NO_HZ=y
 CONFIG_HIGH_RES_TIMERS=y
 CONFIG_LOG_BUF_SHIFT=19
+CONFIG_CGROUPS=y
 CONFIG_BLK_DEV_INITRD=y
 CONFIG_PROFILING=y
 CONFIG_OPROFILE=y
 CONFIG_KPROBES=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
-# CONFIG_BLK_DEV_BSG is not set
 # CONFIG_ARCH_MULTI_V7 is not set
 CONFIG_ARCH_MVEBU=y
 CONFIG_MACH_KIRKWOOD=y
@@ -65,13 +66,14 @@  CONFIG_IP_MULTICAST=y
 CONFIG_IP_PNP=y
 CONFIG_IP_PNP_DHCP=y
 CONFIG_IP_PNP_BOOTP=y
-# CONFIG_IPV6 is not set
 CONFIG_NET_DSA=y
 CONFIG_NET_SWITCHDEV=y
 CONFIG_NET_PKTGEN=m
 CONFIG_CFG80211=y
 CONFIG_MAC80211=y
 CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_IMX_WEIM=y
 CONFIG_MTD=y
 CONFIG_MTD_CMDLINE_PARTS=y