| Message ID | 1459368249-13241-4-git-send-email-boris.brezillon@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote: > pwm->period field is not supposed to be changed by PWM users. The only > ones authorized to change it are the PWM core and PWM drivers. > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/video/backlight/lm3630a_bl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. Thierry
On Tue, 12 Apr 2016, Thierry Reding wrote: > On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote: > > pwm->period field is not supposed to be changed by PWM users. The only > > ones authorized to change it are the PWM core and PWM drivers. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > --- > > drivers/video/backlight/lm3630a_bl.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Applied, thanks. Applied?
On Tue, Apr 12, 2016 at 03:16:13PM +0100, Lee Jones wrote: > On Tue, 12 Apr 2016, Thierry Reding wrote: > > > On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote: > > > pwm->period field is not supposed to be changed by PWM users. The only > > > ones authorized to change it are the PWM core and PWM drivers. > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > --- > > > drivers/video/backlight/lm3630a_bl.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > Applied, thanks. > > Applied? You didn't specifically Ack this one, but I presumed that since the change is essentially the same as for pwm-backlight, and this is another prerequisite for the remainder of the series it should go in through the PWM tree as well. Thierry
On Tue, 12 Apr 2016, Thierry Reding wrote: > On Tue, Apr 12, 2016 at 03:16:13PM +0100, Lee Jones wrote: > > On Tue, 12 Apr 2016, Thierry Reding wrote: > > > > > On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote: > > > > pwm->period field is not supposed to be changed by PWM users. The only > > > > ones authorized to change it are the PWM core and PWM drivers. > > > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > > --- > > > > drivers/video/backlight/lm3630a_bl.c | 3 +-- > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > Applied, thanks. > > > > Applied? > > You didn't specifically Ack this one, but I presumed that since the > change is essentially the same as for pwm-backlight, and this is another > prerequisite for the remainder of the series it should go in through the > PWM tree as well. If you're taking Backlight patches through a !Backlight tree, you're going to have to send out a pull-request. There are no conflicts currently, so I won't use it right away, but I need it in my arsenal if they do occur.
On Wed, 13 Apr 2016, Lee Jones wrote: > On Tue, 12 Apr 2016, Thierry Reding wrote: > > > On Tue, Apr 12, 2016 at 03:16:13PM +0100, Lee Jones wrote: > > > On Tue, 12 Apr 2016, Thierry Reding wrote: > > > > > > > On Wed, Mar 30, 2016 at 10:03:26PM +0200, Boris Brezillon wrote: > > > > > pwm->period field is not supposed to be changed by PWM users. The only > > > > > ones authorized to change it are the PWM core and PWM drivers. > > > > > > > > > > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > > > --- > > > > > drivers/video/backlight/lm3630a_bl.c | 3 +-- > > > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > > Applied, thanks. > > > > > > Applied? > > > > You didn't specifically Ack this one, but I presumed that since the > > change is essentially the same as for pwm-backlight, and this is another > > prerequisite for the remainder of the series it should go in through the > > PWM tree as well. > > If you're taking Backlight patches through a !Backlight tree, you're > going to have to send out a pull-request. There are no conflicts > currently, so I won't use it right away, but I need it in my arsenal > if they do occur. ... also, don't forget to change the subject line to make the rest of the patches in Backlight. The subject description needs to start with an uppercase char.
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index 35fe482..3d16bd6 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -162,7 +162,7 @@ static int lm3630a_intr_config(struct lm3630a_chip *pchip) static void lm3630a_pwm_ctrl(struct lm3630a_chip *pchip, int br, int br_max) { - unsigned int period = pwm_get_period(pchip->pwmd); + unsigned int period = pchip->pdata->pwm_period; unsigned int duty = br * period / br_max; pwm_config(pchip->pwmd, duty, period); @@ -425,7 +425,6 @@ static int lm3630a_probe(struct i2c_client *client, return PTR_ERR(pchip->pwmd); } } - pchip->pwmd->period = pdata->pwm_period; /* interrupt enable : irq 0 is not allowed */ pchip->irq = client->irq;
pwm->period field is not supposed to be changed by PWM users. The only ones authorized to change it are the PWM core and PWM drivers. Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> --- drivers/video/backlight/lm3630a_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)