| Message ID | f20d8fe52f823e7e65423720c53f2935d3e08967.1307040443.git.mika.westerberg@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Mika Westerberg <mika.westerberg@iki.fi> [2011-06-02 21:59:34]: > As the driver is now passing platform device to the DMA mapping functions, > we should give it valid DMA masks. Hi Mika, do you have the series available somewhere for pull? I would like to test the changes for you on my ts7250/ts7300, but I'm quite lazy and would like to just cherry-pick the changes if possible :-) I also wonder, why this patch[1] from Herbert Valerio Riedel has never made it upstream, this email[2] is the last trace of the patch I could find. Looks like Herbert did few fixes to the driver and thanks to Matthieu, I'm using this forward ported patch[3] since today, without any problems. Do you personaly use the ethernet on the ep93xx/ts72xx heavily? 1. http://ynezz.ibawizard.net/ts72xx/linux-kernel/2.6.24.y/ep93xx-eth-phylib-framework.patch 2. http://www.mail-archive.com/netdev@vger.kernel.org/msg62550.html 3. https://github.com/ynezz/linux-2.6/commit/1dcf7aeb7ca4d7e441be2467926b606b46060a44 -- ynezz
On Sun, Jun 05, 2011 at 10:34:45AM +0200, Petr Štetiar wrote: > > do you have the series available somewhere for pull? I would like to test the > changes for you on my ts7250/ts7300, but I'm quite lazy and would like to just > cherry-pick the changes if possible :-) Unfortunately - no. But what's wrong with 'git am <mbox>'? ;-) > I also wonder, why this patch[1] from Herbert Valerio Riedel has never made it > upstream, this email[2] is the last trace of the patch I could find. Looks > like Herbert did few fixes to the driver and thanks to Matthieu, I'm using > this forward ported patch[3] since today, without any problems. I have no idea. It looks like David Miller (CC'd) has been taking care of ep93xx_eth.c maybe he knows this better. > Do you personaly use the ethernet on the ep93xx/ts72xx heavily? Yes, I have NFS roots for the boards so it is essential for me.
Mika Westerberg <mika.westerberg@iki.fi> [2011-06-05 11:59:48]:
> Unfortunately - no. But what's wrong with 'git am <mbox>'? ;-)
Nothing, it's just complicated if you don't read emails on the same machine as
you develop on. Just found patchwork thread, so it's solved[1]. Thanks.
1. https://patchwork.kernel.org/project/linux-arm-kernel/list/
-- ynezz
From: Mika Westerberg <mika.westerberg@iki.fi> Date: Sun, 5 Jun 2011 11:59:48 +0300 > It looks like David Miller (CC'd) has been taking care of ep93xx_eth.c maybe > he knows this better. Someone needs to step up and take over as the real maintainer of this driver. The way the driver is currently being hacked on is unsustainable.
On Sun, Jun 05, 2011 at 02:08:01PM -0700, David Miller wrote: > From: Mika Westerberg <mika.westerberg@iki.fi> > Date: Sun, 5 Jun 2011 11:59:48 +0300 > > > It looks like David Miller (CC'd) has been taking care of ep93xx_eth.c maybe > > he knows this better. > > Someone needs to step up and take over as the real maintainer of this > driver. The way the driver is currently being hacked on is > unsustainable. Can't agree more. Hartley, Ryan: do you have any preferences? Are you guys already overwhelmed with your current maintenance work, or could you consider taking this one as well? If no one else steps up, I can volunteer but I have to admit that I don't know much about that driver.
On Monday, June 06, 2011 10:26 AM, Mika Westerberg wrote: > On Sun, Jun 05, 2011 at 02:08:01PM -0700, David Miller wrote: >> From: Mika Westerberg <mika.westerberg@iki.fi> >> Date: Sun, 5 Jun 2011 11:59:48 +0300 >> >>> It looks like David Miller (CC'd) has been taking care of ep93xx_eth.c maybe >>> he knows this better. >> >> Someone needs to step up and take over as the real maintainer of this >> driver. The way the driver is currently being hacked on is >> unsustainable. > > Can't agree more. > > Hartley, Ryan: do you have any preferences? Are you guys already overwhelmed > with your current maintenance work, or could you consider taking this one as > well? > > If no one else steps up, I can volunteer but I have to admit that I don't know > much about that driver. I feel the same way. If Lennert is no longer maintaining the this driver we really need someone to step up and handle it. I have no problem doing it but I really don't have a good grasp on the driver or the whole network subsystem. If Lennert is willing to hand it over, I have no problem being listed as a co-maintainer along with either yourself of Ryan. Between the two (or three) of us we should be able to handle it. Lennert, You are listed as the maintainer for these EP93xx related pieces: ARM/CIRRUS LOGIC EDB9315A MACHINE SUPPORT CIRRUS LOGIC EP93XX ETHERNET DRIVER CIRRUS LOGIC EP93XX OHCI USB HOST DRIVER I can take over the edb9315a with no problem. It actually falls under arch/arm/mach-ep93xx, so the entry could just be removed from MAINTAINERS. For the OHCI driver, I'm in the same boat as the Ethernet. If you are no longer maintaining this driver I'm willing to handle it but would like someone to step up as a co-maintainer. Hopefully someone that has some grasp of that subsystem. Your also listed in the source as the maintainer of these ep93xx boards: ADSSPHERE adssphere.c EDB9302A edb93xx.c EDB9315 edb93xx.c EDB9315A edb93xx.c GESBC9312 gesbc9312.c TS72XX ts72xx.c I'm willing to handle those also since they are under arch/arm/mach-ep93xx. Regards, Hartley
(corrected Ryan's email address, added Florian Fainelli) On Mon, Jun 06, 2011 at 12:48:19PM -0500, H Hartley Sweeten wrote: > On Monday, June 06, 2011 10:26 AM, Mika Westerberg wrote: > > On Sun, Jun 05, 2011 at 02:08:01PM -0700, David Miller wrote: > >> From: Mika Westerberg <mika.westerberg@iki.fi> > >> Date: Sun, 5 Jun 2011 11:59:48 +0300 > >> > >>> It looks like David Miller (CC'd) has been taking care of ep93xx_eth.c maybe > >>> he knows this better. > >> > >> Someone needs to step up and take over as the real maintainer of this > >> driver. The way the driver is currently being hacked on is > >> unsustainable. > > > > Can't agree more. > > > > Hartley, Ryan: do you have any preferences? Are you guys already overwhelmed > > with your current maintenance work, or could you consider taking this one as > > well? > > > > If no one else steps up, I can volunteer but I have to admit that I don't know > > much about that driver. > > I feel the same way. > > If Lennert is no longer maintaining the this driver we really need someone to > step up and handle it. > > I have no problem doing it but I really don't have a good grasp on the driver > or the whole network subsystem. > > If Lennert is willing to hand it over, I have no problem being listed as a > co-maintainer along with either yourself of Ryan. Between the two (or three) > of us we should be able to handle it. Hartley, Can you take maintainership of this driver? Since you already maintain most of the ep93xx core stuff I think that you are the right person for the job. If you need any assistance I believe me and Ryan can help you out. We have now few patches queued: - this series from me to fix the DMA API violations - phylib patches from Florian Fainelli It would be great to get those in someday :-)
On Thursday, June 09, 2011 12:51 PM, Mika Westerberg wrote: > On Mon, Jun 06, 2011 at 12:48:19PM -0500, H Hartley Sweeten wrote: >> If Lennert is no longer maintaining the this driver we really need someone to >> step up and handle it. >> >> I have no problem doing it but I really don't have a good grasp on the driver >> or the whole network subsystem. >> >> If Lennert is willing to hand it over, I have no problem being listed as a >> co-maintainer along with either yourself of Ryan. Between the two (or three) >> of us we should be able to handle it. > > Hartley, > > Can you take maintainership of this driver? Since you already maintain most of > the ep93xx core stuff I think that you are the right person for the job. If > you need any assistance I believe me and Ryan can help you out. > > We have now few patches queued: > - this series from me to fix the DMA API violations > - phylib patches from Florian Fainelli > > It would be great to get those in someday :-) Hmm.. Ok, fine ;-) I just submitted a patch to lkml changing the maintainership to myself. Patches will still need to be applied through someone's tree, probably David Miller's, since I don't have my own. I think your series and Florian's patches are still in my inbox. I'll try to look at them today and provide feedback. Regards, Hartley
On Thu, Jun 09, 2011 at 03:18:39PM -0500, H Hartley Sweeten wrote: > On Thursday, June 09, 2011 12:51 PM, Mika Westerberg wrote: > > On Mon, Jun 06, 2011 at 12:48:19PM -0500, H Hartley Sweeten wrote: > >> If Lennert is no longer maintaining the this driver we really need someone to > >> step up and handle it. > >> > >> I have no problem doing it but I really don't have a good grasp on the driver > >> or the whole network subsystem. > >> > >> If Lennert is willing to hand it over, I have no problem being listed as a > >> co-maintainer along with either yourself of Ryan. Between the two (or three) > >> of us we should be able to handle it. > > > > Hartley, > > > > Can you take maintainership of this driver? Since you already maintain most of > > the ep93xx core stuff I think that you are the right person for the job. If > > you need any assistance I believe me and Ryan can help you out. > > > > We have now few patches queued: > > - this series from me to fix the DMA API violations > > - phylib patches from Florian Fainelli > > > > It would be great to get those in someday :-) > > Hmm.. Ok, fine ;-) > > I just submitted a patch to lkml changing the maintainership to myself. > > Patches will still need to be applied through someone's tree, probably > David Miller's, since I don't have my own. > > I think your series and Florian's patches are still in my inbox. I'll try > to look at them today and provide feedback. Ok, thanks :-) I was also going to test and review Florian's patches this week. I'll report back when I'm done.
On Thursday, June 02, 2011 12:00 PM, Mika Westerberg wrote: > > As the driver is now passing platform device to the DMA mapping functions, > we should give it valid DMA masks. > > Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk> Since you made this patch the first in the series the commit message is not quite right. Other than that: Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Mika Westerberg <mika.westerberg@iki.fi> [2011-06-05 11:59:48]: > On Sun, Jun 05, 2011 at 10:34:45AM +0200, Petr Štetiar wrote: > > > > do you have the series available somewhere for pull? I would like to test the > > changes for you on my ts7250/ts7300, but I'm quite lazy and would like to just > > cherry-pick the changes if possible :-) > > Unfortunately - no. But what's wrong with 'git am <mbox>'? ;-) I've tested the whole series and didn't find any problems so far, thanks. You can add my Tested-by: Petr Štetiar <ynezz@true.cz> if you wish. -- ynezz
On Fri, Jun 10, 2011 at 05:47:36PM +0200, Petr Štetiar wrote: > > I've tested the whole series and didn't find any problems so far, thanks. You > can add my > > Tested-by: Petr Štetiar <ynezz@true.cz> > > if you wish. Cool. Thanks for testing :)
On Mon, Jun 06, 2011 at 12:48:19PM -0500, H Hartley Sweeten wrote: > Lennert, Hi, > You are listed as the maintainer for these EP93xx related pieces: > > ARM/CIRRUS LOGIC EDB9315A MACHINE SUPPORT > CIRRUS LOGIC EP93XX ETHERNET DRIVER > CIRRUS LOGIC EP93XX OHCI USB HOST DRIVER > > I can take over the edb9315a with no problem. It actually falls under > arch/arm/mach-ep93xx, so the entry could just be removed from MAINTAINERS. If you have the hardware, that's fine with me. > For the OHCI driver, I'm in the same boat as the Ethernet. If you are > no longer maintaining this driver I'm willing to handle it but would > like someone to step up as a co-maintainer. Hopefully someone that > has some grasp of that subsystem. Same here. > Your also listed in the source as the maintainer of these ep93xx boards: > > ADSSPHERE adssphere.c > EDB9302A edb93xx.c > EDB9315 edb93xx.c > EDB9315A edb93xx.c > GESBC9312 gesbc9312.c > TS72XX ts72xx.c > > I'm willing to handle those also since they are under arch/arm/mach-ep93xx. Do you have all these boards, though? thanks, Lennert
diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c index 8207954..1d4b65f 100644 --- a/arch/arm/mach-ep93xx/core.c +++ b/arch/arm/mach-ep93xx/core.c @@ -402,11 +402,15 @@ static struct resource ep93xx_eth_resource[] = { } }; +static u64 ep93xx_eth_dma_mask = DMA_BIT_MASK(32); + static struct platform_device ep93xx_eth_device = { .name = "ep93xx-eth", .id = -1, .dev = { - .platform_data = &ep93xx_eth_data, + .platform_data = &ep93xx_eth_data, + .coherent_dma_mask = DMA_BIT_MASK(32), + .dma_mask = &ep93xx_eth_dma_mask, }, .num_resources = ARRAY_SIZE(ep93xx_eth_resource), .resource = ep93xx_eth_resource,