| Message ID | 1460615074-2492-1-git-send-email-quwenruo@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Apr 14, 2016 at 02:24:34PM +0800, Qu Wenruo wrote: > New btrfs-convert is using a lot of new macro in e2fsprogs 1.42. > Unfortunately the new compatible layer for older e2fsprogs is still > under development. It hasn't been released yet so it's not really a big problem, although it makes testing on my side a bit harder. The configure-time check should be 1.41 and until it's fixed we can print a warning. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
David Sterba wrote on 2016/04/15 13:17 +0200: > On Thu, Apr 14, 2016 at 02:24:34PM +0800, Qu Wenruo wrote: >> New btrfs-convert is using a lot of new macro in e2fsprogs 1.42. >> Unfortunately the new compatible layer for older e2fsprogs is still >> under development. > > It hasn't been released yet so it's not really a big problem, although > it makes testing on my side a bit harder. The configure-time check > should be 1.41 and until it's fixed we can print a warning. > > Did I missed something? I checkout 1.41.14 and it shows no cluster support in ext2fs.h. Also git describe shows it's v1.41.14-36-g1da5ef7, after the last v1.41 version. So I think the check should be 1.42, just as the patch. Thanks, Qu -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 18, 2016 at 09:20:18AM +0800, Qu Wenruo wrote: > > > David Sterba wrote on 2016/04/15 13:17 +0200: > > On Thu, Apr 14, 2016 at 02:24:34PM +0800, Qu Wenruo wrote: > >> New btrfs-convert is using a lot of new macro in e2fsprogs 1.42. > >> Unfortunately the new compatible layer for older e2fsprogs is still > >> under development. > > > > It hasn't been released yet so it's not really a big problem, although > > it makes testing on my side a bit harder. The configure-time check > > should be 1.41 and until it's fixed we can print a warning. > > > > > Did I missed something? > > I checkout 1.41.14 and it shows no cluster support in ext2fs.h. > > Also git describe shows it's v1.41.14-36-g1da5ef7, after the last v1.41 > version. > > So I think the check should be 1.42, just as the patch. The idea is to keep lowest supported version 1.41, because this version can be commonly found on enterprise distros. The lack of cluster is expected and needs to be dealt with both build- and run-time. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/configure.ac b/configure.ac index fc343ea..05fdc32 100644 --- a/configure.ac +++ b/configure.ac @@ -105,7 +105,7 @@ AS_IF([test "x$enable_convert" = xyes], [DISABLE_BTRFSCONVERT=0], [DISABLE_BTRFS AC_SUBST([DISABLE_BTRFSCONVERT]) if test "x$enable_convert" = xyes; then - PKG_CHECK_MODULES(EXT2FS, [ext2fs]) + PKG_CHECK_MODULES(EXT2FS, [ext2fs >= 1.42]) PKG_CHECK_MODULES(COM_ERR, [com_err]) fi
New btrfs-convert is using a lot of new macro in e2fsprogs 1.42. Unfortunately the new compatible layer for older e2fsprogs is still under development. So restrict e2fsprogs version so far to avoid complier error. Reported-by: David Sterba <dsterba@suse.cz> Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)