ARM: davinci_all_defconfig: enable CONFIG_FHANDLE

Commit Message

Sekhar Nori April 15, 2016, 9:46 a.m. UTC

On Monday 11 April 2016 03:59 PM, Sekhar Nori wrote:
> On Saturday 09 April 2016 03:24 AM, Kevin Hilman wrote:
>> Sekhar Nori <[e-mail]> writes:
>>
>>> CONFIG_FHANDLE is required by systemd, which is the
>>> default init system in more and more distributions.
>>
>> There's a bunch more options required for basic systemd support also[1],
>> so those should probably be added with the changelog referencing the
>> source[1]
> 
> Good point. Will send a v2.

I looked at this bit more closely. CONFIG_EPOLL, CONFIG_SIGNALFD, and
CONFIG_TIMERFD are all default y and so actually get removed when the
next 'make savedefconfig' syncup will be done. Same thing for PROC_FS
and SYSFS.

Looking at the list of required options, FHANDLE is the only one which
needs to get enabled explicitly. Also, CONFIG_INOTIFY is actually a
stale entry that can be removed.

Based on this, I think the updated patch can be:

---8<---
From: Sekhar Nori <[e-mail]>
Date: Fri, 15 Apr 2016 14:19:26 +0530
Subject: [PATCH] ARM: davinci_all_defconfig: support systemd

CONFIG_FHANDLE is required by systemd[1], which is the
default init system in more and more distributions.
So lets enable it for DaVinci platforms as well.

While at it, remove stale entry CONFIG_INOTIFY=y

[1] https://github.com/systemd/systemd/blob/master/README#L37

Signed-off-by: Sekhar Nori <[e-mail]>
---
 arch/arm/configs/davinci_all_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kevin Hilman April 18, 2016, 10:46 p.m. UTC | #1

Sekhar Nori <[e-mail]> writes:

> On Monday 11 April 2016 03:59 PM, Sekhar Nori wrote:
>> On Saturday 09 April 2016 03:24 AM, Kevin Hilman wrote:
>>> Sekhar Nori <[e-mail]> writes:
>>>
>>>> CONFIG_FHANDLE is required by systemd, which is the
>>>> default init system in more and more distributions.
>>>
>>> There's a bunch more options required for basic systemd support also[1],
>>> so those should probably be added with the changelog referencing the
>>> source[1]
>> 
>> Good point. Will send a v2.
>
> I looked at this bit more closely. CONFIG_EPOLL, CONFIG_SIGNALFD, and
> CONFIG_TIMERFD are all default y and so actually get removed when the
> next 'make savedefconfig' syncup will be done. Same thing for PROC_FS
> and SYSFS.
>
> Looking at the list of required options, FHANDLE is the only one which
> needs to get enabled explicitly. Also, CONFIG_INOTIFY is actually a
> stale entry that can be removed.
>
> Based on this, I think the updated patch can be:
>
> ---8<---
> From: Sekhar Nori <[e-mail]>
> Date: Fri, 15 Apr 2016 14:19:26 +0530
> Subject: [PATCH] ARM: davinci_all_defconfig: support systemd
>
> CONFIG_FHANDLE is required by systemd[1], which is the
> default init system in more and more distributions.
> So lets enable it for DaVinci platforms as well.
>
> While at it, remove stale entry CONFIG_INOTIFY=y
>
> [1] https://github.com/systemd/systemd/blob/master/README#L37
>
> Signed-off-by: Sekhar Nori <[e-mail]>

Acked-by: Kevin Hilman <[e-mail]>

Sekhar Nori April 25, 2016, 12:49 p.m. UTC | #2

On Tuesday 19 April 2016 04:16 AM, Kevin Hilman wrote:
> Sekhar Nori <[e-mail]> writes:

>> From: Sekhar Nori <[e-mail]>
>> Date: Fri, 15 Apr 2016 14:19:26 +0530
>> Subject: [PATCH] ARM: davinci_all_defconfig: support systemd
>>
>> CONFIG_FHANDLE is required by systemd[1], which is the
>> default init system in more and more distributions.
>> So lets enable it for DaVinci platforms as well.
>>
>> While at it, remove stale entry CONFIG_INOTIFY=y
>>
>> [1] https://github.com/systemd/systemd/blob/master/README#L37
>>
>> Signed-off-by: Sekhar Nori <[e-mail]>
> 
> Acked-by: Kevin Hilman <[e-mail]>

Applied.

Thanks,
Sekhar

Patch

diff --git a/arch/arm/configs/davinci_all_defconfig
b/arch/arm/configs/davinci_all_defconfig
index c5bccd9d010e..776fd8ad792f 100644
--- a/arch/arm/configs/davinci_all_defconfig
+++ b/arch/arm/configs/davinci_all_defconfig
@@ -2,6 +2,7 @@  CONFIG_EXPERIMENTAL=y
 # CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
+CONFIG_FHANDLE=y
 CONFIG_IKCONFIG=y
 CONFIG_IKCONFIG_PROC=y
 CONFIG_LOG_BUF_SHIFT=14
@@ -188,7 +189,6 @@  CONFIG_TI_EDMA=y
 CONFIG_EXT2_FS=y
 CONFIG_EXT3_FS=y
 CONFIG_XFS_FS=m
-CONFIG_INOTIFY=y
 CONFIG_AUTOFS4_FS=m
 CONFIG_MSDOS_FS=y
 CONFIG_VFAT_FS=y