| Message ID | 1461620198-13428-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Tue, Apr 26, 2016 at 12:36:26AM +0300, Laurent Pinchart wrote: > The FCP is a companion module of video processing modules in the Renesas > R-Car Gen3 SoCs. It provides data compression and decompression, data > caching, and conversion of AXI transactions in order to reduce the > memory bandwidth. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > .../devicetree/bindings/media/renesas,fcp.txt | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt > > Cc: devicetree@vger.kernel.org > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt > new file mode 100644 > index 000000000000..0c72ca24379f > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt > @@ -0,0 +1,31 @@ > +Renesas R-Car Frame Compression Processor (FCP) > +----------------------------------------------- > + > +The FCP is a companion module of video processing modules in the Renesas R-Car > +Gen3 SoCs. It provides data compression and decompression, data caching, and > +conversion of AXI transactions in order to reduce the memory bandwidth. > + > +There are three types of FCP whose configuration and behaviour highly depend > +on the module they are paired with. 3 types?, but I only see one compatible and no relationship with said module described. Rob
Hi Rob, On Wednesday 27 Apr 2016 21:54:29 Rob Herring wrote: > On Tue, Apr 26, 2016 at 12:36:26AM +0300, Laurent Pinchart wrote: > > The FCP is a companion module of video processing modules in the Renesas > > R-Car Gen3 SoCs. It provides data compression and decompression, data > > caching, and conversion of AXI transactions in order to reduce the > > memory bandwidth. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > .../devicetree/bindings/media/renesas,fcp.txt | 31 > > ++++++++++++++++++++++ 1 file changed, 31 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/renesas,fcp.txt > > > > Cc: devicetree@vger.kernel.org > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt > > b/Documentation/devicetree/bindings/media/renesas,fcp.txt new file mode > > 100644 > > index 000000000000..0c72ca24379f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt > > @@ -0,0 +1,31 @@ > > +Renesas R-Car Frame Compression Processor (FCP) > > +----------------------------------------------- > > + > > +The FCP is a companion module of video processing modules in the Renesas > > R-Car +Gen3 SoCs. It provides data compression and decompression, data > > caching, and +conversion of AXI transactions in order to reduce the > > memory bandwidth. + > > +There are three types of FCP whose configuration and behaviour highly > > depend +on the module they are paired with. > > 3 types?, but I only see one compatible and no relationship with said > module described. The bindings currently support a single type, as that's all the driver currently supports and I'm not comfortable merging bindings without at least one test implementation. Should I clarify that with something as "These DT bindings currently support the "FCP for Video" type only" ?
On Thu, Apr 28, 2016 at 8:36 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: >> > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt >> > b/Documentation/devicetree/bindings/media/renesas,fcp.txt new file mode >> > 100644 >> > index 000000000000..0c72ca24379f >> > --- /dev/null >> > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt >> > @@ -0,0 +1,31 @@ >> > +Renesas R-Car Frame Compression Processor (FCP) >> > +----------------------------------------------- >> > + >> > +The FCP is a companion module of video processing modules in the Renesas >> > R-Car +Gen3 SoCs. It provides data compression and decompression, data >> > caching, and +conversion of AXI transactions in order to reduce the >> > memory bandwidth. + >> > +There are three types of FCP whose configuration and behaviour highly >> > depend +on the module they are paired with. >> >> 3 types?, but I only see one compatible and no relationship with said >> module described. > > The bindings currently support a single type, as that's all the driver > currently supports and I'm not comfortable merging bindings without at least > one test implementation. Should I clarify that with something as "These DT > bindings currently support the "FCP for Video" type only" ? Yes please. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt new file mode 100644 index 000000000000..0c72ca24379f --- /dev/null +++ b/Documentation/devicetree/bindings/media/renesas,fcp.txt @@ -0,0 +1,31 @@ +Renesas R-Car Frame Compression Processor (FCP) +----------------------------------------------- + +The FCP is a companion module of video processing modules in the Renesas R-Car +Gen3 SoCs. It provides data compression and decompression, data caching, and +conversion of AXI transactions in order to reduce the memory bandwidth. + +There are three types of FCP whose configuration and behaviour highly depend +on the module they are paired with. + + - compatible: Must be one or more of the following + + - "renesas,r8a7795-fcpv" for R8A7795 (R-Car H3) compatible 'FCP for VSP' + - "renesas,fcpv" for generic compatible 'FCP for VSP' + + When compatible with the generic version, nodes must list the + SoC-specific version corresponding to the platform first, followed by the + family-specific and/or generic versions. + + - reg: the register base and size for the device registers + - clocks: Reference to the functional clock + + +Device node example +------------------- + + fcpvd1: fcp@fea2f000 { + compatible = "renesas,r8a7795-fcpv", "renesas,fcpv"; + reg = <0 0xfea2f000 0 0x200>; + clocks = <&cpg CPG_MOD 602>; + };
The FCP is a companion module of video processing modules in the Renesas R-Car Gen3 SoCs. It provides data compression and decompression, data caching, and conversion of AXI transactions in order to reduce the memory bandwidth. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- .../devicetree/bindings/media/renesas,fcp.txt | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt Cc: devicetree@vger.kernel.org