| Message ID | 1461751622-26927-10-git-send-email-tvrtko.ursulin@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Apr 27, 2016 at 11:07:02AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Debug logging in this function does not provide any information > apart that the userspace is calling an ioctl on the connector. > > There is not any info on the connector provided at all and > since there are other ioctls userspace typically calls which > do log useful things about the same connectors, remove this > one to make things a little bit more readable when KMS debugging > is turned on. > > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org Yeah this seems over the top debug noise. If we want this, we could easily add a generic debugfs file, with a lot more info on top. -Daniel > --- > drivers/gpu/drm/drm_crtc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 4e5b015a5e3a..ffb01d91ae32 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -2143,8 +2143,6 @@ int drm_mode_getconnector(struct drm_device *dev, void *data, > > memset(&u_mode, 0, sizeof(struct drm_mode_modeinfo)); > > - DRM_DEBUG_KMS("[CONNECTOR:%d:?]\n", out_resp->connector_id); > - > mutex_lock(&dev->mode_config.mutex); > > connector = drm_connector_find(dev, out_resp->connector_id); > -- > 1.9.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 4e5b015a5e3a..ffb01d91ae32 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -2143,8 +2143,6 @@ int drm_mode_getconnector(struct drm_device *dev, void *data, memset(&u_mode, 0, sizeof(struct drm_mode_modeinfo)); - DRM_DEBUG_KMS("[CONNECTOR:%d:?]\n", out_resp->connector_id); - mutex_lock(&dev->mode_config.mutex); connector = drm_connector_find(dev, out_resp->connector_id);