| Message ID | 1461836938-26008-1-git-send-email-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 28.04.16 at 11:48, <roger.pau@citrix.com> wrote: > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > Config.mk | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Config.mk b/Config.mk > index 9b097c9..67b26dd 100644 > --- a/Config.mk > +++ b/Config.mk > @@ -45,6 +45,12 @@ DESTDIR ?= / > # Allow phony attribute to be listed as dependency rather than fake target > .PHONY: .phony > > +# If we are not cross-compiling, use C{C/XX} as HOSTC{C/XX} I think I'd prefer something like "..., default HOSTC{C/XX} to C{C/XX}" but apart from that (which could be adjusted while committing, if you agree) Acked-by: Jan Beulich <jbeulich@suse.com> (Side note: Please don't forget to Cc Wei on patches targeted at 4.7. And please don't forget to Cc relevant maintainers.) > +ifeq ($(XEN_TARGET_ARCH), $(XEN_COMPILE_ARCH)) > +HOSTCC ?= $(CC) > +HOSTCXX ?= $(CXX) > +endif > + > # Use Clang/LLVM instead of GCC? > clang ?= n > ifeq ($(clang),n) > -- > 2.6.4 (Apple Git-63) > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
On Thu, Apr 28, 2016 at 04:09:46AM -0600, Jan Beulich wrote: > >>> On 28.04.16 at 11:48, <roger.pau@citrix.com> wrote: > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > Config.mk | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Config.mk b/Config.mk > > index 9b097c9..67b26dd 100644 > > --- a/Config.mk > > +++ b/Config.mk > > @@ -45,6 +45,12 @@ DESTDIR ?= / > > # Allow phony attribute to be listed as dependency rather than fake target > > .PHONY: .phony > > > > +# If we are not cross-compiling, use C{C/XX} as HOSTC{C/XX} > > I think I'd prefer something like "..., default HOSTC{C/XX} to C{C/XX}" > but apart from that (which could be adjusted while committing, if you > agree) > Acked-by: Jan Beulich <jbeulich@suse.com> That's fine by me (and more accurate than my original message). > (Side note: Please don't forget to Cc Wei on patches targeted at 4.7. > And please don't forget to Cc relevant maintainers.) Yes, my bad. I've actually forgotten to Cc anyone on this patch, sigh... Roger.
On Thu, Apr 28, 2016 at 04:09:46AM -0600, Jan Beulich wrote: > >>> On 28.04.16 at 11:48, <roger.pau@citrix.com> wrote: > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > Config.mk | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Config.mk b/Config.mk > > index 9b097c9..67b26dd 100644 > > --- a/Config.mk > > +++ b/Config.mk > > @@ -45,6 +45,12 @@ DESTDIR ?= / > > # Allow phony attribute to be listed as dependency rather than fake target > > .PHONY: .phony > > > > +# If we are not cross-compiling, use C{C/XX} as HOSTC{C/XX} > > I think I'd prefer something like "..., default HOSTC{C/XX} to C{C/XX}" > but apart from that (which could be adjusted while committing, if you > agree) > Acked-by: Jan Beulich <jbeulich@suse.com> > > (Side note: Please don't forget to Cc Wei on patches targeted at 4.7. > And please don't forget to Cc relevant maintainers.) Release-acked-by: Wei Liu <wei.liu2@citrix.com> > > > +ifeq ($(XEN_TARGET_ARCH), $(XEN_COMPILE_ARCH)) > > +HOSTCC ?= $(CC) > > +HOSTCXX ?= $(CXX) > > +endif > > + > > # Use Clang/LLVM instead of GCC? > > clang ?= n > > ifeq ($(clang),n) > > -- > > 2.6.4 (Apple Git-63) > > > > > > _______________________________________________ > > Xen-devel mailing list > > Xen-devel@lists.xen.org > > http://lists.xen.org/xen-devel > >
diff --git a/Config.mk b/Config.mk index 9b097c9..67b26dd 100644 --- a/Config.mk +++ b/Config.mk @@ -45,6 +45,12 @@ DESTDIR ?= / # Allow phony attribute to be listed as dependency rather than fake target .PHONY: .phony +# If we are not cross-compiling, use C{C/XX} as HOSTC{C/XX} +ifeq ($(XEN_TARGET_ARCH), $(XEN_COMPILE_ARCH)) +HOSTCC ?= $(CC) +HOSTCXX ?= $(CXX) +endif + # Use Clang/LLVM instead of GCC? clang ?= n ifeq ($(clang),n)
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Config.mk | 6 ++++++ 1 file changed, 6 insertions(+)