| Message ID | 1462272910-41200-3-git-send-email-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 03, 2016 at 12:55:06PM +0200, Roger Pau Monne wrote: > Some error paths incorrectly used rc instead of errno. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com> > --- > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: Ross Lagerwall <ross.lagerwall@citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > --- > Changes since v1: > - Fix error message. > --- > tools/misc/xen-xsplice.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c > index 0f1ab5a..598e492 100644 > --- a/tools/misc/xen-xsplice.c > +++ b/tools/misc/xen-xsplice.c > @@ -272,8 +272,8 @@ int action_func(int argc, char *argv[], unsigned int idx) > rc = xc_xsplice_get(xch, name, &status); > if ( rc ) > { > - fprintf(stderr, "%s failed to get status (rc=%d, %s)!\n", > - name, -rc, strerror(-rc)); > + fprintf(stderr, "%s failed to get status %d(%s)!\n", > + name, errno, strerror(errno)); > return -1; > } > if ( status.rc == -EAGAIN ) > @@ -295,7 +295,8 @@ int action_func(int argc, char *argv[], unsigned int idx) > rc = action_options[idx].function(xch, name, 0); > if ( rc ) > { > - fprintf(stderr, "%s failed with %d(%s)\n", name, -rc, strerror(-rc)); > + fprintf(stderr, "%s failed with %d(%s)\n", name, errno, > + strerror(errno)); > return -1; > } > } > -- > 2.6.4 (Apple Git-63) >
diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c index 0f1ab5a..598e492 100644 --- a/tools/misc/xen-xsplice.c +++ b/tools/misc/xen-xsplice.c @@ -272,8 +272,8 @@ int action_func(int argc, char *argv[], unsigned int idx) rc = xc_xsplice_get(xch, name, &status); if ( rc ) { - fprintf(stderr, "%s failed to get status (rc=%d, %s)!\n", - name, -rc, strerror(-rc)); + fprintf(stderr, "%s failed to get status %d(%s)!\n", + name, errno, strerror(errno)); return -1; } if ( status.rc == -EAGAIN ) @@ -295,7 +295,8 @@ int action_func(int argc, char *argv[], unsigned int idx) rc = action_options[idx].function(xch, name, 0); if ( rc ) { - fprintf(stderr, "%s failed with %d(%s)\n", name, -rc, strerror(-rc)); + fprintf(stderr, "%s failed with %d(%s)\n", name, errno, + strerror(errno)); return -1; } }
Some error paths incorrectly used rc instead of errno. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Ross Lagerwall <ross.lagerwall@citrix.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> --- Changes since v1: - Fix error message. --- tools/misc/xen-xsplice.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)