| Message ID | 1462451666-17945-14-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Krzysztof, On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: > On Odroid U3 (Exynos4412-based) board if USB was initialized by > bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) > and LAN (smsc95xx) after after successful probing were not visible in the > system ("lsusb"). > > In such case the devices had to be fully reset before configuring. > Reset by GPIO (called RESET_N pin) and by RESET field in STCD register > in usb3503 HUB are not sufficient. Instead full reset has to be done by > disabling and enabling regulator. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- [snip] > > + lan_pwrseq: pwrseq2 { > + compatible = "mmc-pwrseq-simple"; It feels strange to have a "mmc-pwrseq-simple" compatible for a USB power sequence provider. As I mentioned in the other patch, I think there should either be a DT binding for the USB pwrseq-simple with a "usb-pwrseq-simple" compatible that binds to the same pwrseq-simple driver or maybe having a generic DT binding for any device with a new "pwrseq-simple" compatible. Patch looks good to me though, so after having a DT binding and changing the compatible string: Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On 05/05/2016 10:16 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> On Odroid U3 (Exynos4412-based) board if USB was initialized by >> bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) >> and LAN (smsc95xx) after after successful probing were not visible in the >> system ("lsusb"). >> >> In such case the devices had to be fully reset before configuring. >> Reset by GPIO (called RESET_N pin) and by RESET field in STCD register >> in usb3503 HUB are not sufficient. Instead full reset has to be done by >> disabling and enabling regulator. >> >> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> --- > > [snip] > >> >> + lan_pwrseq: pwrseq2 { >> + compatible = "mmc-pwrseq-simple"; > > It feels strange to have a "mmc-pwrseq-simple" compatible for a USB power > sequence provider. As I mentioned in the other patch, I think there should > either be a DT binding for the USB pwrseq-simple with a "usb-pwrseq-simple" > compatible that binds to the same pwrseq-simple driver or maybe having a > generic DT binding for any device with a new "pwrseq-simple" compatible. > > Patch looks good to me though, so after having a DT binding and changing > the compatible string: > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Probably this will change after Rob's feedback. :) Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index 14e653e32e0f..efa204a85c83 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -67,7 +67,7 @@ }; }; - emmc_pwrseq: pwrseq { + emmc_pwrseq: pwrseq1 { pinctrl-0 = <&sd1_cd>; pinctrl-names = "default"; compatible = "mmc-pwrseq-emmc"; diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts index 31cdc036fda4..3da0e6b3c32a 100644 --- a/arch/arm/boot/dts/exynos4412-odroidu3.dts +++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts @@ -41,6 +41,11 @@ cooling-levels = <0 102 170 230>; }; + lan_pwrseq: pwrseq2 { + compatible = "mmc-pwrseq-simple"; + ext-supply = <&buck8_reg>; + }; + thermal-zones { cpu_thermal: cpu-thermal { cooling-maps { @@ -104,6 +109,7 @@ &ehci { port@1 { status = "okay"; + usb-pwrseq = <&lan_pwrseq>; }; port@2 { status = "okay";
On Odroid U3 (Exynos4412-based) board if USB was initialized by bootloader (in U-Boot "usb start" before tftpboot), the HUB (usb3503) and LAN (smsc95xx) after after successful probing were not visible in the system ("lsusb"). In such case the devices had to be fully reset before configuring. Reset by GPIO (called RESET_N pin) and by RESET field in STCD register in usb3503 HUB are not sufficient. Instead full reset has to be done by disabling and enabling regulator. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 2 +- arch/arm/boot/dts/exynos4412-odroidu3.dts | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-)