diff mbox

[1/2] ARM: dts: igep00x0: Add SD card-detect.

Message ID 1462568554-7868-1-git-send-email-enric.balletbo@collabora.com (mailing list archive)
State New, archived
Headers show

Commit Message

Enric Balletbo i Serra May 6, 2016, 9:02 p.m. UTC 
Fix SD card remove/insert detection by adding the correct card-detect
pin. All IGEP OMAP3 based boards use the same card-detect pin.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 arch/arm/boot/dts/omap3-igep.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Javier Martinez Canillas May 6, 2016, 9:07 p.m. UTC | #1 
Hello Enric,

On Fri, May 6, 2016 at 5:02 PM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> Fix SD card remove/insert detection by adding the correct card-detect
> pin. All IGEP OMAP3 based boards use the same card-detect pin.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>

Shouldn't his be Suggested-by: Ladislav Michl <ladis@linux-mips.org> instead?

Or if the patch was originally from Ladis, then he should remain the
author with your S-o-B after his.

Patch looks good to me though.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Javier
Enric Balletbo i Serra May 6, 2016, 9:22 p.m. UTC | #2 
Hi Javier,

On 06/05/16 23:07, Javier Martinez Canillas wrote:
> Hello Enric,
> 
> On Fri, May 6, 2016 at 5:02 PM, Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
>> Fix SD card remove/insert detection by adding the correct card-detect
>> pin. All IGEP OMAP3 based boards use the same card-detect pin.
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> 
> Shouldn't his be Suggested-by: Ladislav Michl <ladis@linux-mips.org> instead?
> 
> Or if the patch was originally from Ladis, then he should remain the
> author with your S-o-B after his.
> 

Well Ladis sent the same patch as I had in my local repository for long
time, so to be strict the correct is have two authors and two S-o-B. My bad
is not send the patch before.

> Patch looks good to me though.
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Best regards,
> Javier
>
Javier Martinez Canillas May 6, 2016, 9:27 p.m. UTC | #3 
Hello Enric,

On Fri, May 6, 2016 at 5:22 PM, Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
> Hi Javier,
>
> On 06/05/16 23:07, Javier Martinez Canillas wrote:
>> Hello Enric,
>>
>> On Fri, May 6, 2016 at 5:02 PM, Enric Balletbo i Serra
>> <enric.balletbo@collabora.com> wrote:
>>> Fix SD card remove/insert detection by adding the correct card-detect
>>> pin. All IGEP OMAP3 based boards use the same card-detect pin.
>>>
>>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
>>> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
>>
>> Shouldn't his be Suggested-by: Ladislav Michl <ladis@linux-mips.org> instead?
>>
>> Or if the patch was originally from Ladis, then he should remain the
>> author with your S-o-B after his.
>>
>
> Well Ladis sent the same patch as I had in my local repository for long
> time, so to be strict the correct is have two authors and two S-o-B. My bad
> is not send the patch before.
>

Got it, then I think is correct to have both S-o-B. Thanks for the
clarification.

Best regards,
Javier
Tony Lindgren May 12, 2016, 8:53 p.m. UTC | #4 
* Javier Martinez Canillas <javier@dowhile0.org> [160506 14:28]:
> Hello Enric,
> 
> On Fri, May 6, 2016 at 5:22 PM, Enric Balletbo i Serra
> <enric.balletbo@collabora.com> wrote:
> > Hi Javier,
> >
> > On 06/05/16 23:07, Javier Martinez Canillas wrote:
> >> Hello Enric,
> >>
> >> On Fri, May 6, 2016 at 5:02 PM, Enric Balletbo i Serra
> >> <enric.balletbo@collabora.com> wrote:
> >>> Fix SD card remove/insert detection by adding the correct card-detect
> >>> pin. All IGEP OMAP3 based boards use the same card-detect pin.
> >>>
> >>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> >>> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> >>
> >> Shouldn't his be Suggested-by: Ladislav Michl <ladis@linux-mips.org> instead?
> >>
> >> Or if the patch was originally from Ladis, then he should remain the
> >> author with your S-o-B after his.
> >>
> >
> > Well Ladis sent the same patch as I had in my local repository for long
> > time, so to be strict the correct is have two authors and two S-o-B. My bad
> > is not send the patch before.
> 
> Got it, then I think is correct to have both S-o-B. Thanks for the
> clarification.

OK thanks for checking, applying both into omap-for-v4.7/dt.

Tony
diff mbox

Patch

diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index 41f5d38..f4f2ce4 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -188,6 +188,7 @@ 
 	vmmc-supply = <&vmmc1>;
 	vmmc_aux-supply = <&vsim>;
 	bus-width = <4>;
+	cd-gpios = <&twl_gpio 0 GPIO_ACTIVE_LOW>;
 };
 
 &mmc3 {