| Message ID | 1462797277-14969-2-git-send-email-joel@jms.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 09, 2016 at 10:04:36PM +0930, Joel Stanley wrote: > Signed-off-by: Joel Stanley <joel@jms.id.au> > --- > Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > new file mode 100644 > index 000000000000..58184b161e0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > @@ -0,0 +1,14 @@ > +Aspeed Watchdog Timer > + > +Required properties: > + - compatible: must be "aspeed,wdt" This should have the specific SOCs listed. Rob > + - reg: physical base address of the controller and length of memory mapped > + region > + > +Example: > + > + wdt1: wdt@1e785000 { IIRC, "watchdog@..." is the correct generic name. > + compatible = "aspeed,wdt"; > + reg = <0x1e785000 0x1c>; > + interrupts = <27>; > + }; > -- > 2.8.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 10, 2016 at 6:08 AM, Rob Herring <robh@kernel.org> wrote: > On Mon, May 09, 2016 at 10:04:36PM +0930, Joel Stanley wrote: >> Signed-off-by: Joel Stanley <joel@jms.id.au> >> --- >> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 14 ++++++++++++++ >> 1 file changed, 14 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> >> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> new file mode 100644 >> index 000000000000..58184b161e0d >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> @@ -0,0 +1,14 @@ >> +Aspeed Watchdog Timer >> + >> +Required properties: >> + - compatible: must be "aspeed,wdt" > > This should have the specific SOCs listed. Thanks, I'll fix it. In the cases where the drivers had no change in the IP between versions of the soc I wondered if it was neater to have a generic string. You're saying that's wrong and we prefer using multiple strings for all the SoCs instead? >> + wdt1: wdt@1e785000 { > > IIRC, "watchdog@..." is the correct generic name. Cheers, Joel
diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt new file mode 100644 index 000000000000..58184b161e0d --- /dev/null +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt @@ -0,0 +1,14 @@ +Aspeed Watchdog Timer + +Required properties: + - compatible: must be "aspeed,wdt" + - reg: physical base address of the controller and length of memory mapped + region + +Example: + + wdt1: wdt@1e785000 { + compatible = "aspeed,wdt"; + reg = <0x1e785000 0x1c>; + interrupts = <27>; + };
Signed-off-by: Joel Stanley <joel@jms.id.au> --- Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt