| Message ID | 1462950412-16681-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hi Krzysztof, Sorry for not acting on the feedback sooner - I lost the email in my Inbox! I've tested the patch on my Origen board and it works fine. One small comment in-line. Krzysztof Kozlowski <k.kozlowski@samsung.com> writes: > From: Matthew Leach <matthew@mattleach.net> > > Enable the Origen's usb phy and ohci devices in the device tree. Also > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so > the AX88760 hub is powered. > > Signed-off-by: Matthew Leach <matthew@mattleach.net> > [k.kozlowski: Extend nodes by label notation instead of path] > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts > index 8bca699b7f20..4c59bdb0e6f3 100644 > --- a/arch/arm/boot/dts/exynos4412-origen.dts > +++ b/arch/arm/boot/dts/exynos4412-origen.dts > @@ -77,12 +77,29 @@ > clock-frequency = <24000000>; > }; > }; > + I think we could loose this line break? Thanks,
On Wed, May 11, 2016 at 07:18:31PM +0100, Matthew Leach wrote: > Hi Krzysztof, > > Sorry for not acting on the feedback sooner - I lost the email in my > Inbox! > > I've tested the patch on my Origen board and it works fine. One small > comment in-line. > > Krzysztof Kozlowski <k.kozlowski@samsung.com> writes: > > > From: Matthew Leach <matthew@mattleach.net> > > > > Enable the Origen's usb phy and ohci devices in the device tree. Also > > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so > > the AX88760 hub is powered. > > > > Signed-off-by: Matthew Leach <matthew@mattleach.net> > > [k.kozlowski: Extend nodes by label notation instead of path] > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts > > index 8bca699b7f20..4c59bdb0e6f3 100644 > > --- a/arch/arm/boot/dts/exynos4412-origen.dts > > +++ b/arch/arm/boot/dts/exynos4412-origen.dts > > @@ -77,12 +77,29 @@ > > clock-frequency = <24000000>; > > }; > > }; > > + > > I think we could loose this line break? Yeah, that slipped through my fingers. Thanks for testing, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts index 8bca699b7f20..4c59bdb0e6f3 100644 --- a/arch/arm/boot/dts/exynos4412-origen.dts +++ b/arch/arm/boot/dts/exynos4412-origen.dts @@ -77,12 +77,29 @@ clock-frequency = <24000000>; }; }; + }; &cpu0 { cpu0-supply = <&buck2_reg>; }; +&exynos_usbphy { + status = "okay"; +}; + +&ehci { + samsung,vbus-gpio = <&gpx3 5 1>; + status = "okay"; + + port@1{ + status = "okay"; + }; + port@2 { + status = "okay"; + }; +}; + &fimd { pinctrl-0 = <&lcd_clk &lcd_data24 &pwm1_out>; pinctrl-names = "default";