| Message ID | 1463397984-15766-2-git-send-email-vigneshr@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 16, 2016 at 04:56:22PM +0530, Vignesh R wrote: > On AM335x, ti_am335x_tsc can wake up the system from suspend, mark the > IRQ as wakeup capable, so that device irq is not disabled during system > suspend. I would love for platform core to do this for us, like I2C core does. > > Signed-off-by: Vignesh R <vigneshr@ti.com> > --- > drivers/input/touchscreen/ti_am335x_tsc.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > index 8b3f15ca7725..f9fefbe337b9 100644 > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > @@ -27,6 +27,7 @@ > #include <linux/of.h> > #include <linux/of_device.h> > #include <linux/sort.h> > +#include <linux/pm_wakeirq.h> > > #include <linux/mfd/ti_am335x_tscadc.h> > > @@ -432,6 +433,12 @@ static int titsc_probe(struct platform_device *pdev) > goto err_free_mem; > } > > + if (device_may_wakeup(tscadc_dev->dev)) { > + err = dev_pm_set_wake_irq(tscadc_dev->dev, ts_dev->irq); > + if (err) > + dev_err(&pdev->dev, "irq wake enable failed.\n"); > + } > + > titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_FIFO0THRES); > titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_EOS); > err = titsc_config_wires(ts_dev); > @@ -462,6 +469,7 @@ static int titsc_probe(struct platform_device *pdev) > return 0; > > err_free_irq: > + dev_pm_clear_wake_irq(tscadc_dev->dev); > free_irq(ts_dev->irq, ts_dev); > err_free_mem: > input_free_device(input_dev); > @@ -474,6 +482,7 @@ static int titsc_remove(struct platform_device *pdev) > struct titsc *ts_dev = platform_get_drvdata(pdev); > u32 steps; > > + dev_pm_clear_wake_irq(ts_dev->mfd_tscadc->dev); > free_irq(ts_dev->irq, ts_dev); > > /* total steps followed by the enable mask */ > -- > 2.8.2 >
On 05/17/2016 01:16 AM, Dmitry Torokhov wrote: > On Mon, May 16, 2016 at 04:56:22PM +0530, Vignesh R wrote: >> On AM335x, ti_am335x_tsc can wake up the system from suspend, mark the >> IRQ as wakeup capable, so that device irq is not disabled during system >> suspend. > > I would love for platform core to do this for us, like I2C core does. Ok, I will replicate the same in input_register_device() for input core.
diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index 8b3f15ca7725..f9fefbe337b9 100644 --- a/drivers/input/touchscreen/ti_am335x_tsc.c +++ b/drivers/input/touchscreen/ti_am335x_tsc.c @@ -27,6 +27,7 @@ #include <linux/of.h> #include <linux/of_device.h> #include <linux/sort.h> +#include <linux/pm_wakeirq.h> #include <linux/mfd/ti_am335x_tscadc.h> @@ -432,6 +433,12 @@ static int titsc_probe(struct platform_device *pdev) goto err_free_mem; } + if (device_may_wakeup(tscadc_dev->dev)) { + err = dev_pm_set_wake_irq(tscadc_dev->dev, ts_dev->irq); + if (err) + dev_err(&pdev->dev, "irq wake enable failed.\n"); + } + titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_FIFO0THRES); titsc_writel(ts_dev, REG_IRQENABLE, IRQENB_EOS); err = titsc_config_wires(ts_dev); @@ -462,6 +469,7 @@ static int titsc_probe(struct platform_device *pdev) return 0; err_free_irq: + dev_pm_clear_wake_irq(tscadc_dev->dev); free_irq(ts_dev->irq, ts_dev); err_free_mem: input_free_device(input_dev); @@ -474,6 +482,7 @@ static int titsc_remove(struct platform_device *pdev) struct titsc *ts_dev = platform_get_drvdata(pdev); u32 steps; + dev_pm_clear_wake_irq(ts_dev->mfd_tscadc->dev); free_irq(ts_dev->irq, ts_dev); /* total steps followed by the enable mask */
On AM335x, ti_am335x_tsc can wake up the system from suspend, mark the IRQ as wakeup capable, so that device irq is not disabled during system suspend. Signed-off-by: Vignesh R <vigneshr@ti.com> --- drivers/input/touchscreen/ti_am335x_tsc.c | 9 +++++++++ 1 file changed, 9 insertions(+)