| Message ID | 1463759301-30930-1-git-send-email-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Anthony PERARD writes ("[PATCH] docs: Fix device_model_user description of its default value"):
> docs/misc/qemu-deprivilege.txt and libxl suggest that "xen-qemuuser" is
> the default prefix, reflect that in the man.
>
> Also add some emphasis.
I'm going to make a perhaps-controversial suggestion:
This feature should be deprecated for 4.7. Specifically,
- the warning about running qemu as root should go away
- the docs should mention that running qemu not as root
may well break things
Right now, the privsep is not finished and I think trying to run qemu
as non-root won't (usually) actually work.
Ian.
On 20/05/16 17:34, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH] docs: Fix device_model_user description of its default value"): >> docs/misc/qemu-deprivilege.txt and libxl suggest that "xen-qemuuser" is >> the default prefix, reflect that in the man. >> >> Also add some emphasis. > I'm going to make a perhaps-controversial suggestion: > > This feature should be deprecated for 4.7. Specifically, > - the warning about running qemu as root should go away > - the docs should mention that running qemu not as root > may well break things Definitely does break migration (as reported back around Christmas). Probably breaks other things. The warning is definitely annoying, and not helpful. ~Andrew
On Fri, May 20, 2016 at 05:34:10PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH] docs: Fix device_model_user description of its default value"): > > docs/misc/qemu-deprivilege.txt and libxl suggest that "xen-qemuuser" is > > the default prefix, reflect that in the man. > > > > Also add some emphasis. > > I'm going to make a perhaps-controversial suggestion: > > This feature should be deprecated for 4.7. Specifically, > - the warning about running qemu as root should go away > - the docs should mention that running qemu not as root > may well break things Yes. The doc bearly mention an issue with migration and pci passthrough. I could boot a guest, but shutdown did not work. > Right now, the privsep is not finished and I think trying to run qemu > as non-root won't (usually) actually work. > > Ian.
On Fri, May 20, 2016 at 05:48:37PM +0100, Anthony PERARD wrote: > On Fri, May 20, 2016 at 05:34:10PM +0100, Ian Jackson wrote: > > Anthony PERARD writes ("[PATCH] docs: Fix device_model_user description of its default value"): > > > docs/misc/qemu-deprivilege.txt and libxl suggest that "xen-qemuuser" is > > > the default prefix, reflect that in the man. > > > > > > Also add some emphasis. > > > > I'm going to make a perhaps-controversial suggestion: > > > > This feature should be deprecated for 4.7. Specifically, > > - the warning about running qemu as root should go away > > - the docs should mention that running qemu not as root > > may well break things > > Yes. The doc bearly mention an issue with migration and pci passthrough. > I could boot a guest, but shutdown did not work. > So I guess we should just remove relevant manpage sections? The code can be left as-is so that we can develop this thing further. Wei. > > Right now, the privsep is not finished and I think trying to run qemu > > as non-root won't (usually) actually work. > > > > Ian. > > -- > Anthony PERARD
On Fri, May 20, 2016 at 5:53 PM, Wei Liu <wei.liu2@citrix.com> wrote: > On Fri, May 20, 2016 at 05:48:37PM +0100, Anthony PERARD wrote: >> On Fri, May 20, 2016 at 05:34:10PM +0100, Ian Jackson wrote: >> > Anthony PERARD writes ("[PATCH] docs: Fix device_model_user description of its default value"): >> > > docs/misc/qemu-deprivilege.txt and libxl suggest that "xen-qemuuser" is >> > > the default prefix, reflect that in the man. >> > > >> > > Also add some emphasis. >> > >> > I'm going to make a perhaps-controversial suggestion: >> > >> > This feature should be deprecated for 4.7. Specifically, >> > - the warning about running qemu as root should go away >> > - the docs should mention that running qemu not as root >> > may well break things >> >> Yes. The doc bearly mention an issue with migration and pci passthrough. >> I could boot a guest, but shutdown did not work. >> > > So I guess we should just remove relevant manpage sections? The code can > be left as-is so that we can develop this thing further. I agree that if we're not going to actually recommend people use this feature yet that the warning should go away. -George
diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 index a4cc1b3..accd9b4 100644 --- a/docs/man/xl.cfg.pod.5 +++ b/docs/man/xl.cfg.pod.5 @@ -1952,7 +1952,7 @@ option to the device-model. =item B<device_model_user="username"> Run the device model as user "username", instead of -xen-qemudepriv-domid$domid or xen-qemudepriv-shared or root. +B<xen-qemuuser-domid$domid> or B<xen-qemuuser-shared> or B<root>. Please note that running QEMU as non-root causes migration and PCI passthrough not to work properly.
docs/misc/qemu-deprivilege.txt and libxl suggest that "xen-qemuuser" is the default prefix, reflect that in the man. Also add some emphasis. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- docs/man/xl.cfg.pod.5 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)