| Message ID | 1463988616-18803-1-git-send-email-henryc.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 23, 2016 at 03:30:16PM +0800, Henry Chen wrote:
> Consitify the structure of regulator operations.
Oh, actually the mode setting patch does apply but it depends on this
one (which was sent after...). It would have been better to send a
patch series for the driver and separately a patch series for the core,
the driver changes are orthogonal to the core ones here.
Hi Mark, On Mon, 2016-05-23 at 12:32 +0100, Mark Brown wrote: > On Mon, May 23, 2016 at 03:30:16PM +0800, Henry Chen wrote: > > Consitify the structure of regulator operations. > > Oh, actually the mode setting patch does apply but it depends on this > one (which was sent after...). It would have been better to send a > patch series for the driver and separately a patch series for the core, > the driver changes are orthogonal to the core ones here. Got it. Sorry for unawareness of the dependency issue and thanks for kindly reminder.
diff --git a/drivers/regulator/mt6397-regulator.c b/drivers/regulator/mt6397-regulator.c index 17a5b6c..1c45abb 100644 --- a/drivers/regulator/mt6397-regulator.c +++ b/drivers/regulator/mt6397-regulator.c @@ -160,7 +160,7 @@ static int mt6397_get_status(struct regulator_dev *rdev) return (regval & info->qi) ? REGULATOR_STATUS_ON : REGULATOR_STATUS_OFF; } -static struct regulator_ops mt6397_volt_range_ops = { +static const struct regulator_ops mt6397_volt_range_ops = { .list_voltage = regulator_list_voltage_linear_range, .map_voltage = regulator_map_voltage_linear_range, .set_voltage_sel = regulator_set_voltage_sel_regmap, @@ -172,7 +172,7 @@ static struct regulator_ops mt6397_volt_range_ops = { .get_status = mt6397_get_status, }; -static struct regulator_ops mt6397_volt_table_ops = { +static const struct regulator_ops mt6397_volt_table_ops = { .list_voltage = regulator_list_voltage_table, .map_voltage = regulator_map_voltage_iterate, .set_voltage_sel = regulator_set_voltage_sel_regmap, @@ -184,7 +184,7 @@ static struct regulator_ops mt6397_volt_table_ops = { .get_status = mt6397_get_status, }; -static struct regulator_ops mt6397_volt_fixed_ops = { +static const struct regulator_ops mt6397_volt_fixed_ops = { .list_voltage = regulator_list_voltage_linear, .enable = regulator_enable_regmap, .disable = regulator_disable_regmap,
Consitify the structure of regulator operations. Signed-off-by: Henry Chen <henryc.chen@mediatek.com> --- drivers/regulator/mt6397-regulator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)