| Message ID | 1464101136-4767-1-git-send-email-anthony.perard@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, May 24, 2016 at 03:45:36PM +0100, Anthony PERARD wrote: > Running QEMU as non-root user is not ready yet, so replace the warning > with a debug message and remove the option from the man page. > > Also improve the doc to include more potential issue with running QEMU > as non-root. > > Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
Anthony PERARD writes ("[PATCH v2] libxl: Avoid advertising about device_model_user config option"):
> Running QEMU as non-root user is not ready yet, so replace the warning
> with a debug message and remove the option from the man page.
>
> Also improve the doc to include more potential issue with running QEMU
> as non-root.
LGTM
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 index a4cc1b3..4a8bf51 100644 --- a/docs/man/xl.cfg.pod.5 +++ b/docs/man/xl.cfg.pod.5 @@ -1949,13 +1949,6 @@ Pass additional arbitrary options on the device-model command line for an HVM device model only. Each element in the list is passed as an option to the device-model. -=item B<device_model_user="username"> - -Run the device model as user "username", instead of -xen-qemudepriv-domid$domid or xen-qemudepriv-shared or root. -Please note that running QEMU as non-root causes migration and PCI -passthrough not to work properly. - =back =head2 Keymaps diff --git a/docs/misc/qemu-deprivilege.txt b/docs/misc/qemu-deprivilege.txt index 879a98e..58b86a3 100644 --- a/docs/misc/qemu-deprivilege.txt +++ b/docs/misc/qemu-deprivilege.txt @@ -31,5 +31,6 @@ adduser --no-create-home --system xen-qemuuser-shared As a last resort, libxl will start QEMU as root. -Please note that running QEMU as non-root causes migration and PCI -passthrough not to work properly. +Please note that running QEMU as non-root causes several features like +migration and PCI passthrough to not work properly and may prevent the guest +from booting. diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 65dceee..6bbc7c3 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -1482,7 +1482,7 @@ static int libxl__build_device_model_args_new(libxl__gc *gc, } user = NULL; - LOG(WARN, "Could not find user %s, starting QEMU as root", + LOG(DEBUG, "Could not find user %s, starting QEMU as root", LIBXL_QEMU_USER_SHARED); end_search: diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index 9840f3b..ef614be 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -468,6 +468,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("device_model", string), ("device_model_ssidref", uint32), ("device_model_ssid_label", string), + # device_model_user is not ready for use yet ("device_model_user", string), # extra parameters pass directly to qemu, NULL terminated
Running QEMU as non-root user is not ready yet, so replace the warning with a debug message and remove the option from the man page. Also improve the doc to include more potential issue with running QEMU as non-root. Signed-off-by: Anthony PERARD <anthony.perard@citrix.com> --- Changes in V2: - remove option from the man page - add a comment in the IDL. --- docs/man/xl.cfg.pod.5 | 7 ------- docs/misc/qemu-deprivilege.txt | 5 +++-- tools/libxl/libxl_dm.c | 2 +- tools/libxl/libxl_types.idl | 1 + 4 files changed, 5 insertions(+), 10 deletions(-)