diff mbox

[3/3] input/alps: Add device description for Dell Latitude E7470

Message ID 1464252914-11450-4-git-send-email-ben@smart-cactus.org (mailing list archive)
State New, archived
Headers show

Commit Message

Ben Gamari May 26, 2016, 8:55 a.m. UTC 
---
 drivers/input/mouse/alps.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Pali Rohár May 26, 2016, 9:05 a.m. UTC | #1 
On Thursday 26 May 2016 10:55:14 Ben Gamari wrote:
> ---
>  drivers/input/mouse/alps.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index 10e6836..eb4bf31 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -143,6 +143,7 @@ static const struct alps_model_info alps_model_data[] = {
>  	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* Toshiba Tecra A11-11L */
>  	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
> +	{ { 0x73, 0x03, 0x28 }, 0x00, { ALPS_PROTO_V8, 0x18, 0x18, ALPS_SS4_V2_ALT_DECODING | ALPS_DUALPOINT } }, /* Dell Latitude E7470 */
>  };
>  
>  static const struct alps_protocol_info alps_v3_protocol_data = {

Hi! I would rather move this code into alps_identify and probably create
alps_v8_ss<name>_data structure for it.

Above alps_model_data list looks like hooks for special touchpads which
needs more flags to work correctly...
Hans de Goede May 26, 2016, 12:19 p.m. UTC | #2 
Hi,

On 26-05-16 11:05, Pali Rohár wrote:
> On Thursday 26 May 2016 10:55:14 Ben Gamari wrote:
>> ---
>>  drivers/input/mouse/alps.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
>> index 10e6836..eb4bf31 100644
>> --- a/drivers/input/mouse/alps.c
>> +++ b/drivers/input/mouse/alps.c
>> @@ -143,6 +143,7 @@ static const struct alps_model_info alps_model_data[] = {
>>  	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
>>  		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* Toshiba Tecra A11-11L */
>>  	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
>> +	{ { 0x73, 0x03, 0x28 }, 0x00, { ALPS_PROTO_V8, 0x18, 0x18, ALPS_SS4_V2_ALT_DECODING | ALPS_DUALPOINT } }, /* Dell Latitude E7470 */
>>  };
>>
>>  static const struct alps_protocol_info alps_v3_protocol_data = {
>
> Hi! I would rather move this code into alps_identify and probably create
> alps_v8_ss<name>_data structure for it.
>
> Above alps_model_data list looks like hooks for special touchpads which
> needs more flags to work correctly...

Agreed, the alps_model_data array is really only used for quirks for old touchpads
and should not be used for new touchpads.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pali Rohár May 26, 2016, 12:35 p.m. UTC | #3 
On Thursday 26 May 2016 14:19:18 Hans de Goede wrote:
> Hi,
> 
> On 26-05-16 11:05, Pali Rohár wrote:
> >On Thursday 26 May 2016 10:55:14 Ben Gamari wrote:
> >>---
> >> drivers/input/mouse/alps.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> >>index 10e6836..eb4bf31 100644
> >>--- a/drivers/input/mouse/alps.c
> >>+++ b/drivers/input/mouse/alps.c
> >>@@ -143,6 +143,7 @@ static const struct alps_model_info alps_model_data[] = {
> >> 	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
> >> 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* Toshiba Tecra A11-11L */
> >> 	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
> >>+	{ { 0x73, 0x03, 0x28 }, 0x00, { ALPS_PROTO_V8, 0x18, 0x18, ALPS_SS4_V2_ALT_DECODING | ALPS_DUALPOINT } }, /* Dell Latitude E7470 */
> >> };
> >>
> >> static const struct alps_protocol_info alps_v3_protocol_data = {
> >
> >Hi! I would rather move this code into alps_identify and probably create
> >alps_v8_ss<name>_data structure for it.
> >
> >Above alps_model_data list looks like hooks for special touchpads which
> >needs more flags to work correctly...
> 
> Agreed, the alps_model_data array is really only used for quirks for old touchpads
> and should not be used for new touchpads.

Ben: Or maybe new structure for alps_identify is not needed at all. Just
set flags based on e7 data (if it has 0x28 or not).
diff mbox

Patch

diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index 10e6836..eb4bf31 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -143,6 +143,7 @@  static const struct alps_model_info alps_model_data[] = {
 	{ { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
 		ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } },				/* Toshiba Tecra A11-11L */
 	{ { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
+	{ { 0x73, 0x03, 0x28 }, 0x00, { ALPS_PROTO_V8, 0x18, 0x18, ALPS_SS4_V2_ALT_DECODING | ALPS_DUALPOINT } }, /* Dell Latitude E7470 */
 };
 
 static const struct alps_protocol_info alps_v3_protocol_data = {