[RESEND,03/10] <linux/sunrpc/svcauth.h>: Define hash_str() in terms of hash_string()

Commit Message

J. Bruce Fields May 27, 2016, 12:16 p.m. UTC

On Thu, May 26, 2016 at 11:29:46PM -0400, George Spelvin wrote:
> Okay, it's now okay to re-pull.  I renamed mine to hashlen_string(),
> since that's what it returns (the hash and the length), which both
> solves the problem,and is frankly a better name.
> 
> Thank you for prodding me to wade through the GCC 6 warning
> spam.  Thre were some problems hiding there.
> 
> I discovered that adding #include <linux/bug.h> breaks the tools.perf
> build.  It makes local copies of some kernel headers under control of
> a MANIFEST file, and I can't be arsed to figure it out.
> 
> So I deleted the BUILD_BUG_ON entirely, and it's now (finally!) finished
> an allyesconfig build without any warnings that look new.

I also needed the following.

That still gets me some compiler warnings in gfs2, but looks like code
your patches don't touch, so that's probably a preexisting gfs2 problem.

But... the resulting kernel isn't booting succesfully for me.  Not sure
what's up there, I'll investigate some more.

--b.

commit 5168cb717b37ef0b183dee9b411a85831b558b9b
Author: J. Bruce Fields <[e-mail]>
Date:   Fri May 27 07:10:21 2016 -0400

    XXX

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

George Spelvin May 27, 2016, 12:20 p.m. UTC | #1

> I also needed the following.

I just found out five mintues ago that the push last night failed
because I forgot the -f.  :-( *Now* it'll pull and work.

> But... the resulting kernel isn't booting succesfully for me.  Not sure
> what's up there, I'll investigate some more.

Thank you *so much* for the help, but do get the latest.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

George Spelvin May 27, 2016, 5:14 p.m. UTC | #2

> But... the resulting kernel isn't booting succesfully for me.  Not sure
> what's up there, I'll investigate some more.

On a 32-bit machine, a listing of /proc shows self, but stat /proc/self
returns ENOENT.  Very odd, am investigating.  Thank you again for
catching things I managed to miss, I've since found several glitches.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

J. Bruce Fields May 27, 2016, 5:40 p.m. UTC | #3

On Fri, May 27, 2016 at 08:20:22AM -0400, George Spelvin wrote:
> > I also needed the following.
> 
> I just found out five mintues ago that the push last night failed
> because I forgot the -f.  :-( *Now* it'll pull and work.
> 
> > But... the resulting kernel isn't booting succesfully for me.  Not sure
> > what's up there, I'll investigate some more.
> 
> Thank you *so much* for the help, but do get the latest.

I don't see yet what the problem is, but I can tell you that as of
95d5dfa805a6344e69ef41f56bb4955269079ec7 "fs/namei.c: Improve dcache
hash function" my (Fedora 21 x86_64) VM no longer starts up reliably....

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/linux/hash.h b/include/linux/hash.h
index 1afde47..21b8ebc 100644
--- a/include/linux/hash.h
+++ b/include/linux/hash.h
@@ -15,6 +15,7 @@ 
  */
 
 #include <asm/types.h>
+#include <linux/bug.h>
 #include <linux/compiler.h>
 
 /* 2^31 + 2^29 - 2^25 + 2^22 - 2^19 - 2^16 + 1 */