| Message ID | 1465301018-9671-1-git-send-email-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Hello Marek, On 06/07/2016 08:03 AM, Marek Szyprowski wrote: > Generic reserved memory regions bindings allow to automatically allocate > region of given parameters (alignment and size), so use this feature > instead of the hardcoded values, which had no dependency on the real > hardware. This patch also increases "left" region from 8MiB to 16MiB to > make the codec really usable with nowadays steams (with 8MiB reserved > region it was not even possible to decode 480p H264 video). > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- The patch looks good to me and I've also tested it on an Exynos5800 Peach Pi Chromebook and an Exynos5420 Odroid XU4 board. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Tested-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On 06/07/2016 02:03 PM, Marek Szyprowski wrote: > Generic reserved memory regions bindings allow to automatically allocate > region of given parameters (alignment and size), so use this feature > instead of the hardcoded values, which had no dependency on the real > hardware. This patch also increases "left" region from 8MiB to 16MiB to > make the codec really usable with nowadays steams (with 8MiB reserved > region it was not even possible to decode 480p H264 video). > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos-mfc-reserved-memory.dtsi | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Applied all three on top of topic branch. Thanks, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/exynos-mfc-reserved-memory.dtsi b/arch/arm/boot/dts/exynos-mfc-reserved-memory.dtsi index c4d063a..da3ced9 100644 --- a/arch/arm/boot/dts/exynos-mfc-reserved-memory.dtsi +++ b/arch/arm/boot/dts/exynos-mfc-reserved-memory.dtsi @@ -14,16 +14,18 @@ #size-cells = <1>; ranges; - mfc_left: region@51000000 { + mfc_left: region_mfc_left { compatible = "shared-dma-pool"; no-map; - reg = <0x51000000 0x800000>; + size = <0x1000000>; + alignment = <0x100000>; }; - mfc_right: region@43000000 { + mfc_right: region_mfc_right { compatible = "shared-dma-pool"; no-map; - reg = <0x43000000 0x800000>; + size = <0x800000>; + alignment = <0x100000>; }; }; };
Generic reserved memory regions bindings allow to automatically allocate region of given parameters (alignment and size), so use this feature instead of the hardcoded values, which had no dependency on the real hardware. This patch also increases "left" region from 8MiB to 16MiB to make the codec really usable with nowadays steams (with 8MiB reserved region it was not even possible to decode 480p H264 video). Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos-mfc-reserved-memory.dtsi | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)