| Message ID | 1464934708-24769-2-git-send-email-kraxel@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jun 3, 2016 at 8:18 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > There is no ARCH_BCM on arm64, and we need pinctrl-bcm2835 for the rpi3. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/pinctrl/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile > index e4bc115..88586c0 100644 > --- a/drivers/pinctrl/Makefile > +++ b/drivers/pinctrl/Makefile > @@ -35,7 +35,7 @@ obj-$(CONFIG_PINCTRL_TB10X) += pinctrl-tb10x.o > obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o > obj-$(CONFIG_PINCTRL_ZYNQ) += pinctrl-zynq.o > > -obj-$(CONFIG_ARCH_BCM) += bcm/ > +obj-y += bcm/ Looks OK to me, but would like Stephen's or Eric's ACK? Yours, Linus Walleij
Linus Walleij <linus.walleij@linaro.org> writes: > On Fri, Jun 3, 2016 at 8:18 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > >> There is no ARCH_BCM on arm64, and we need pinctrl-bcm2835 for the rpi3. >> >> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> >> --- >> drivers/pinctrl/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile >> index e4bc115..88586c0 100644 >> --- a/drivers/pinctrl/Makefile >> +++ b/drivers/pinctrl/Makefile >> @@ -35,7 +35,7 @@ obj-$(CONFIG_PINCTRL_TB10X) += pinctrl-tb10x.o >> obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o >> obj-$(CONFIG_PINCTRL_ZYNQ) += pinctrl-zynq.o >> >> -obj-$(CONFIG_ARCH_BCM) += bcm/ >> +obj-y += bcm/ > > Looks OK to me, but would like Stephen's or Eric's ACK? It looks like this is the only instance of filtering the directory on CONFIG_ARCH_BCM, so regardless of the patch 4 resolution, Acked-by: Eric Anholt <eric@anholt.net>
On Fri, Jun 3, 2016 at 8:18 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > There is no ARCH_BCM on arm64, and we need pinctrl-bcm2835 for the rpi3. > > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> I see I got an identical patch from Florian Fainelli and applied it. Sorry for my clashes, confusion and screwups... Added Eric's ACK on the applied patch. Yours, Linus Walleij
Linus Walleij <linus.walleij@linaro.org> writes: > On Fri, Jun 3, 2016 at 8:18 AM, Gerd Hoffmann <kraxel@redhat.com> wrote: > >> There is no ARCH_BCM on arm64, and we need pinctrl-bcm2835 for the rpi3. >> >> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > > I see I got an identical patch from Florian Fainelli and applied it. > Sorry for my clashes, confusion and screwups... Added Eric's > ACK on the applied patch. Florian's had a nice commit message, and I'm just happy to see patches land. Thanks!
diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile index e4bc115..88586c0 100644 --- a/drivers/pinctrl/Makefile +++ b/drivers/pinctrl/Makefile @@ -35,7 +35,7 @@ obj-$(CONFIG_PINCTRL_TB10X) += pinctrl-tb10x.o obj-$(CONFIG_PINCTRL_ST) += pinctrl-st.o obj-$(CONFIG_PINCTRL_ZYNQ) += pinctrl-zynq.o -obj-$(CONFIG_ARCH_BCM) += bcm/ +obj-y += bcm/ obj-$(CONFIG_PINCTRL_BERLIN) += berlin/ obj-y += freescale/ obj-$(CONFIG_X86) += intel/
There is no ARCH_BCM on arm64, and we need pinctrl-bcm2835 for the rpi3. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- drivers/pinctrl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)