Message ID | 1466107475-9747-1-git-send-email-jmkrzyszt@gmail.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 86c0ae7cde7a8699116b365a5e3016753f0cd92a |
Headers | show |
On Thu, Jun 16, 2016 at 10:04:35PM +0200, Janusz Krzysztofik wrote: > Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), > introduced in v3.10, revealed a bug in the cx20442 codec driver > which has never been setting tty->receive_room on line discipline > open as it should from the beginning. Fix it. Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for people to identify relevant patches.
diff --git a/sound/soc/codecs/cx20442.c b/sound/soc/codecs/cx20442.c index d6f4abb..fb3885f 100644 --- a/sound/soc/codecs/cx20442.c +++ b/sound/soc/codecs/cx20442.c @@ -226,6 +226,7 @@ static int v253_open(struct tty_struct *tty) if (!tty->disc_data) return -ENODEV; + tty->receive_room = 16; if (tty->ops->write(tty, v253_init, len) != len) { ret = -EIO; goto err;
Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), introduced in v3.10, revealed a bug in the cx20442 codec driver which has never been setting tty->receive_room on line discipline open as it should from the beginning. Fix it. Created and tested on Amstrad Delta against Linux-4.7-rc3 Signed-off-by: Janusz Krzysztofik <jmkrzyszt@gmail.com> --- sound/soc/codecs/cx20442.c | 1 + 1 file changed, 1 insertion(+)