| Message ID | 1466175913-19067-2-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Friday, June 17, 2016 4:05:05 PM CEST Ben Dooks wrote: > The function pcibios_report_status() needs a declaration to avoid > the following warning, so declare it in <asm/pci.h>. > > /home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: linux-arm-kernel@lists.infradead.org > Cc: Russell King <linux@armlinux.org.uk> > Cc: Bjorn Helgaas <bhelgaas@google.com> > --- > arch/arm/include/asm/pci.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h > index 057d381..4b5ea93 100644 > --- a/arch/arm/include/asm/pci.h > +++ b/arch/arm/include/asm/pci.h > @@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) > return channel ? 15 : 14; > } > > +extern void pcibios_report_status(unsigned int status_mask, int warn); > + > #endif /* __KERNEL__ */ > #endif > Should we remove the declaration in arch/arm/mach-footbridge/dc21285.c at the same time? Another option would be to move the function to that file and make it static, since nothing else uses it. Arnd
diff --git a/arch/arm/include/asm/pci.h b/arch/arm/include/asm/pci.h index 057d381..4b5ea93 100644 --- a/arch/arm/include/asm/pci.h +++ b/arch/arm/include/asm/pci.h @@ -37,5 +37,7 @@ static inline int pci_get_legacy_ide_irq(struct pci_dev *dev, int channel) return channel ? 15 : 14; } +extern void pcibios_report_status(unsigned int status_mask, int warn); + #endif /* __KERNEL__ */ #endif
The function pcibios_report_status() needs a declaration to avoid the following warning, so declare it in <asm/pci.h>. /home/ben/kernel/linux/arch/arm/kernel/bios32.c:58:6: warning: symbol 'pcibios_report_status' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: linux-arm-kernel@lists.infradead.org Cc: Russell King <linux@armlinux.org.uk> Cc: Bjorn Helgaas <bhelgaas@google.com> --- arch/arm/include/asm/pci.h | 2 ++ 1 file changed, 2 insertions(+)