| Message ID | 1466173280-23797-1-git-send-email-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/06/16 15:21, Wei Liu wrote: > Signed-off-by: Wei Liu <wei.liu2@citrix.com> LGTM, although a couple of comments. > --- > tests/fep/Makefile | 12 ++++++++++++ > tests/fep/main.c | 31 +++++++++++++++++++++++++++++++ Please add this to the test index in docs/all-tests.dox > 2 files changed, 43 insertions(+) > create mode 100644 tests/fep/Makefile > create mode 100644 tests/fep/main.c > > diff --git a/tests/fep/Makefile b/tests/fep/Makefile > new file mode 100644 > index 0000000..8702123 > --- /dev/null > +++ b/tests/fep/Makefile > @@ -0,0 +1,12 @@ > +MAKEFLAGS += -r > +ROOT := $(abspath $(CURDIR)/../..) > + > +include $(ROOT)/build/common.mk > + > +NAME := fep > +CATEGORY := utility > +TEST-ENVS := $(HVM_ENVIRONMENTS) This really doesn't need to be all HVM environments. FEP is a property of the HVM container, not of the running mode of the domain. hvm32 would be fine here, and the most simple option. > + > +obj-perenv += main.o > + > +include $(ROOT)/build/gen.mk > diff --git a/tests/fep/main.c b/tests/fep/main.c > new file mode 100644 > index 0000000..34a93c0 > --- /dev/null > +++ b/tests/fep/main.c > @@ -0,0 +1,31 @@ > +/** > + * @file tests/fep/main.c > + * @ref test-fep > + * > + * @page test-fep FEP > + * > + * Returns SUCCESS if FEP is available, FAILURE if not. This is the content one will find from the test index, and as such, should be the most complete. At the very least, I would add a sentence explaining what FEP is. ~Andrew
On Mon, Jun 20, 2016 at 02:43:47PM +0100, Andrew Cooper wrote: > On 17/06/16 15:21, Wei Liu wrote: > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > LGTM, although a couple of comments. > > > --- > > tests/fep/Makefile | 12 ++++++++++++ > > tests/fep/main.c | 31 +++++++++++++++++++++++++++++++ > > Please add this to the test index in docs/all-tests.dox > Done. > > 2 files changed, 43 insertions(+) > > create mode 100644 tests/fep/Makefile > > create mode 100644 tests/fep/main.c > > > > diff --git a/tests/fep/Makefile b/tests/fep/Makefile > > new file mode 100644 > > index 0000000..8702123 > > --- /dev/null > > +++ b/tests/fep/Makefile > > @@ -0,0 +1,12 @@ > > +MAKEFLAGS += -r > > +ROOT := $(abspath $(CURDIR)/../..) > > + > > +include $(ROOT)/build/common.mk > > + > > +NAME := fep > > +CATEGORY := utility > > +TEST-ENVS := $(HVM_ENVIRONMENTS) > > This really doesn't need to be all HVM environments. FEP is a property > of the HVM container, not of the running mode of the domain. hvm32 > would be fine here, and the most simple option. > Done. > > + > > +obj-perenv += main.o > > + > > +include $(ROOT)/build/gen.mk > > diff --git a/tests/fep/main.c b/tests/fep/main.c > > new file mode 100644 > > index 0000000..34a93c0 > > --- /dev/null > > +++ b/tests/fep/main.c > > @@ -0,0 +1,31 @@ > > +/** > > + * @file tests/fep/main.c > > + * @ref test-fep > > + * > > + * @page test-fep FEP > > + * > > + * Returns SUCCESS if FEP is available, FAILURE if not. > > This is the content one will find from the test index, and as such, > should be the most complete. At the very least, I would add a sentence > explaining what FEP is. > Sure. V2 coming soon. Wei. > ~Andrew
diff --git a/tests/fep/Makefile b/tests/fep/Makefile new file mode 100644 index 0000000..8702123 --- /dev/null +++ b/tests/fep/Makefile @@ -0,0 +1,12 @@ +MAKEFLAGS += -r +ROOT := $(abspath $(CURDIR)/../..) + +include $(ROOT)/build/common.mk + +NAME := fep +CATEGORY := utility +TEST-ENVS := $(HVM_ENVIRONMENTS) + +obj-perenv += main.o + +include $(ROOT)/build/gen.mk diff --git a/tests/fep/main.c b/tests/fep/main.c new file mode 100644 index 0000000..34a93c0 --- /dev/null +++ b/tests/fep/main.c @@ -0,0 +1,31 @@ +/** + * @file tests/fep/main.c + * @ref test-fep + * + * @page test-fep FEP + * + * Returns SUCCESS if FEP is available, FAILURE if not. + * + * @sa tests/fep/main.c + */ +#include <xtf.h> + +void test_main(void) +{ + printk("Test availability of HVM forced emulation prefix\n"); + + if ( xtf_has_fep ) + xtf_success(NULL); + else + xtf_failure(NULL); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * tab-width: 4 + * indent-tabs-mode: nil + * End: + */
Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- tests/fep/Makefile | 12 ++++++++++++ tests/fep/main.c | 31 +++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) create mode 100644 tests/fep/Makefile create mode 100644 tests/fep/main.c