diff mbox

[16/17] xen: Make FLASK_AVC_STATS kconfig option visible

Message ID 1466431466-28055-17-git-send-email-dgdegra@tycho.nsa.gov (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel De Graaf June 20, 2016, 2:04 p.m. UTC
Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
---
 xen/common/Kconfig | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Douglas Goldstein June 20, 2016, 2:49 p.m. UTC | #1
On 6/20/16 9:04 AM, Daniel De Graaf wrote:
> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>

Reviewed-by: Doug Goldstein <cardoe@cardoe.com>


> ---
>  xen/common/Kconfig | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index 6a51fd5..8fb5a68 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -134,9 +134,14 @@ config FLASK
>  
>  config FLASK_AVC_STATS
>  	def_bool y
> +	prompt "Maintain statistics on the FLASK access vector cache" if EXPERT = "y"

This is what I was thinking you need to do for patch 13.
diff mbox

Patch

diff --git a/xen/common/Kconfig b/xen/common/Kconfig
index 6a51fd5..8fb5a68 100644
--- a/xen/common/Kconfig
+++ b/xen/common/Kconfig
@@ -134,9 +134,14 @@  config FLASK
 
 config FLASK_AVC_STATS
 	def_bool y
+	prompt "Maintain statistics on the FLASK access vector cache" if EXPERT = "y"
 	depends on FLASK
 	---help---
-	  Maintain statistics on the access vector cache
+	  Maintain counters on the access vector cache that can be viewed using
+	  the FLASK_AVC_CACHESTATS sub-op of the xsm_op hypercall.  Disabling
+	  this will save a tiny amount of memory and time to update the stats.
+
+	  If unsure, say Y.
 
 # Enable schedulers
 menu "Schedulers"