| Message ID | 1466452907-23290-2-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote: > This patch adds apq8096 db820c basic support with serial port. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > arch/arm64/boot/dts/qcom/Makefile | 2 +- > arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 21 +++++++++++++++++ > arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts > create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index fa1f661..80ecdfe 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -1,5 +1,5 @@ > dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb > -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb We should do a new line for each board as other arm64 vendors have done? > diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > new file mode 100644 > index 0000000..e1a55b1 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts > @@ -0,0 +1,21 @@ > +/* > + * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 and > + * only version 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +/dts-v1/; > + > +#include "apq8096-db820c.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. DB820c"; > + compatible = "qcom,apq8096-db820c"; Should be qcom,apq8096-sbc? At least I have to use that on my board to match the board ids.
On 21/06/16 00:23, Stephen Boyd wrote: > On 06/20/2016 01:01 PM, Srinivas Kandagatla wrote: >> This patch adds apq8096 db820c basic support with serial port. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 2 +- >> arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 21 +++++++++++++++++ >> arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++ >> 3 files changed, 56 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts >> create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index fa1f661..80ecdfe 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -1,5 +1,5 @@ >> dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb >> -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb > > We should do a new line for each board as other arm64 vendors have done? I agree, Will fix this in next version. > >> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts >> new file mode 100644 >> +/dts-v1/; >> + >> +#include "apq8096-db820c.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. DB820c"; >> + compatible = "qcom,apq8096-db820c"; > > Should be qcom,apq8096-sbc? At least I have to use that on my board to > match the board ids. I agree, this should match up with the dtbTool. I have been manually patching up dtb to include the board-id, pmic id stuff. I will fix it in next version, Did not look at full details but, For some reason dtbTool does not support multiple compatible strings, do you think it makes sense to add this support in dtb tool to cope up with compatible strings like: compatible = "qcom,apq8096-db820c", "qcom,apq8096-sbc"; Thanks, srini >
On 06/21, Srinivas Kandagatla wrote: > I agree, this should match up with the dtbTool. I have been manually > patching up dtb to include the board-id, pmic id stuff. Uh oh :/ > > I will fix it in next version, > > Did not look at full details but, For some reason dtbTool does not > support multiple compatible strings, do you think it makes sense to > add this support in dtb tool to cope up with compatible strings > like: > > compatible = "qcom,apq8096-db820c", "qcom,apq8096-sbc"; > Hmm I suppose we can add support to look for the first compatible that matches something that we can generate an id for? That would allow us to have the LK compatible and then whatever is more specific than that which the bootloader doesn't care about.
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index fa1f661..80ecdfe 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -1,5 +1,5 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8016-sbc.dtb msm8916-mtp.dtb -dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb apq8096-db820c.dtb always := $(dtb-y) subdir-y := $(dts-dirs) diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts new file mode 100644 index 0000000..e1a55b1 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts @@ -0,0 +1,21 @@ +/* + * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +/dts-v1/; + +#include "apq8096-db820c.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. DB820c"; + compatible = "qcom,apq8096-db820c"; +}; diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi new file mode 100644 index 0000000..01916a5 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi @@ -0,0 +1,34 @@ +/* + * Copyright (c) 2014-2016, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 and + * only version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include "msm8996.dtsi" + +/ { + aliases { + serial0 = &blsp2_uart1; + }; + + chosen { + stdout-path = "serial0"; + }; + + soc { + serial@75b0000 { + label = "LS-UART1"; + status = "okay"; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&blsp2_uart1_2pins_default>; + pinctrl-1 = <&blsp2_uart1_2pins_sleep>; + }; + }; +};
This patch adds apq8096 db820c basic support with serial port. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- arch/arm64/boot/dts/qcom/Makefile | 2 +- arch/arm64/boot/dts/qcom/apq8096-db820c.dts | 21 +++++++++++++++++ arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi | 34 ++++++++++++++++++++++++++++ 3 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dts create mode 100644 arch/arm64/boot/dts/qcom/apq8096-db820c.dtsi