diff mbox

[v4,22/22] sh: Renesas RTS7751R2Dplus (a,k.a R2Dplus) DeviceTree

Message ID 1467207667-15768-23-git-send-email-ysato@users.sourceforge.jp (mailing list archive)
State New, archived
Headers show

Commit Message

Yoshinori Sato June 29, 2016, 1:41 p.m. UTC 
Changes v4
- split patch

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
 arch/sh/boot/dts/Makefile    |  1 +
 arch/sh/boot/dts/r2dplus.dts | 83 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
 create mode 100644 arch/sh/boot/dts/r2dplus.dts

Comments

Sergei Shtylyov June 29, 2016, 2:16 p.m. UTC | #1 
On 06/29/2016 04:41 PM, Yoshinori Sato wrote:

> Changes v4
> - split patch
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>

[...]

> diff --git a/arch/sh/boot/dts/r2dplus.dts b/arch/sh/boot/dts/r2dplus.dts
> new file mode 100644
> index 0000000..a1a0745
> --- /dev/null
> +++ b/arch/sh/boot/dts/r2dplus.dts
> @@ -0,0 +1,83 @@
> +/dts-v1/;
> +
> +#include "sh7751.dtsi"
> +
> +/ {
> +	model = "Renesas RTS7751R2D+";

    The ePAPR standard says:

The recommended format is: “manufacturer,model”, where manufacturer is a 
string describing the name of the manufacturer (such as a stock ticker 
symbol), and model specifies the model number.

> +	compatible = "renesas,r2dplus";
> +	#address-cells = <1>;
> +	#size-cells = <1>;
> +	interrupt-parent = <&shintc>;
> +	chosen {
> +		stdout-path = &sci1;
> +		bootargs = "console=ttySC1,115200";
> +	};
> +	aliases {
> +		serial1 = &sci1;
> +	};
> +
> +	memory@0c000000 {
> +		device_type = "memory";
> +		reg = <0x0c000000 0x4000000>;
> +	};

    Need empty line here...

> +	fpgaintc: fpga@a4000000 {
> +		compatible = "renesas,r2dplus-intc";
> +		#interrupt-cells = <1>;
> +		interrupt-controller;
> +		reg = <0xa4000000 0x40>;
> +		interrupt-map=<0 &shintc evt2irq(0x200)>,
> +		              <1 &shintc evt2irq(0x220)>,
> +		              <2 &shintc evt2irq(0x240)>,
> +			      <3 &shintc evt2irq(0x260)>,
> +		              <4 &shintc evt2irq(0x280)>,
> +			      <5 &shintc evt2irq(0x2a0)>,
> +		              <6 &shintc evt2irq(0x2c0)>,
> +			      <7 &shintc evt2irq(0x2e0)>,
> +		              <8 &shintc evt2irq(0x300)>,
> +			      <9 &shintc evt2irq(0x320)>,
> +		              <10 &shintc evt2irq(0x340)>,
> +			      <11 &shintc evt2irq(0x360)>,
> +		              <12 &shintc evt2irq(0x380)>,
> +			      <13 &shintc evt2irq(0x3a0)>,
> +		              <14 &shintc evt2irq(0x3c0)>;
> +	};
> +	pata: pata@b4001000 {

    This node should be named "ide@..." to comply with ePAPR.

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yoshinori Sato June 30, 2016, 2:47 p.m. UTC | #2 
On Wed, 29 Jun 2016 23:16:52 +0900,
Sergei Shtylyov wrote:
> 
> On 06/29/2016 04:41 PM, Yoshinori Sato wrote:
> 
> > Changes v4
> > - split patch
> > 
> > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> 
> [...]
> 
> > diff --git a/arch/sh/boot/dts/r2dplus.dts b/arch/sh/boot/dts/r2dplus.dts
> > new file mode 100644
> > index 0000000..a1a0745
> > --- /dev/null
> > +++ b/arch/sh/boot/dts/r2dplus.dts
> > @@ -0,0 +1,83 @@
> > +/dts-v1/;
> > +
> > +#include "sh7751.dtsi"
> > +
> > +/ {
> > +	model = "Renesas RTS7751R2D+";
> 
>    The ePAPR standard says:
> 
> The recommended format is: “manufacturer,model”, where manufacturer
> is a string describing the name of the manufacturer (such as a stock
> ticker symbol), and model specifies the model number.

OK.
I lookd ePAPR standard.

> > +	compatible = "renesas,r2dplus";
> > +	#address-cells = <1>;
> > +	#size-cells = <1>;
> > +	interrupt-parent = <&shintc>;
> > +	chosen {
> > +		stdout-path = &sci1;
> > +		bootargs = "console=ttySC1,115200";
> > +	};
> > +	aliases {
> > +		serial1 = &sci1;
> > +	};
> > +
> > +	memory@0c000000 {
> > +		device_type = "memory";
> > +		reg = <0x0c000000 0x4000000>;
> > +	};
> 
>    Need empty line here...
>
> > +	fpgaintc: fpga@a4000000 {
> > +		compatible = "renesas,r2dplus-intc";
> > +		#interrupt-cells = <1>;
> > +		interrupt-controller;
> > +		reg = <0xa4000000 0x40>;
> > +		interrupt-map=<0 &shintc evt2irq(0x200)>,
> > +		              <1 &shintc evt2irq(0x220)>,
> > +		              <2 &shintc evt2irq(0x240)>,
> > +			      <3 &shintc evt2irq(0x260)>,
> > +		              <4 &shintc evt2irq(0x280)>,
> > +			      <5 &shintc evt2irq(0x2a0)>,
> > +		              <6 &shintc evt2irq(0x2c0)>,
> > +			      <7 &shintc evt2irq(0x2e0)>,
> > +		              <8 &shintc evt2irq(0x300)>,
> > +			      <9 &shintc evt2irq(0x320)>,
> > +		              <10 &shintc evt2irq(0x340)>,
> > +			      <11 &shintc evt2irq(0x360)>,
> > +		              <12 &shintc evt2irq(0x380)>,
> > +			      <13 &shintc evt2irq(0x3a0)>,
> > +		              <14 &shintc evt2irq(0x3c0)>;
> > +	};
> > +	pata: pata@b4001000 {
> 
>    This node should be named "ide@..." to comply with ePAPR.

OK.
Thanks.

> MBR, Sergei
>
diff mbox

Patch

diff --git a/arch/sh/boot/dts/Makefile b/arch/sh/boot/dts/Makefile
index cf5aec4..e059ce2b 100644
--- a/arch/sh/boot/dts/Makefile
+++ b/arch/sh/boot/dts/Makefile
@@ -1,6 +1,7 @@ 
 obj-$(CONFIG_USE_BUILTIN_DTB) += $(patsubst "%",%,$(CONFIG_BUILTIN_DTB_SOURCE)).dtb.o
 
 dtb-y += landisk.dtb
+otb-y += r2dplus.dtb
 
 dtstree		:= $(srctree)/$(src)
 clean-files := *.dtb.S
diff --git a/arch/sh/boot/dts/r2dplus.dts b/arch/sh/boot/dts/r2dplus.dts
new file mode 100644
index 0000000..a1a0745
--- /dev/null
+++ b/arch/sh/boot/dts/r2dplus.dts
@@ -0,0 +1,83 @@ 
+/dts-v1/;
+
+#include "sh7751.dtsi"
+
+/ {
+	model = "Renesas RTS7751R2D+";
+	compatible = "renesas,r2dplus";
+	#address-cells = <1>;
+	#size-cells = <1>;
+	interrupt-parent = <&shintc>;
+	chosen {
+		stdout-path = &sci1;
+		bootargs = "console=ttySC1,115200";
+	};
+	aliases {
+		serial1 = &sci1;
+	};
+
+	memory@0c000000 {
+		device_type = "memory";
+		reg = <0x0c000000 0x4000000>;
+	};
+	fpgaintc: fpga@a4000000 {
+		compatible = "renesas,r2dplus-intc";
+		#interrupt-cells = <1>;
+		interrupt-controller;
+		reg = <0xa4000000 0x40>;
+		interrupt-map=<0 &shintc evt2irq(0x200)>,
+		              <1 &shintc evt2irq(0x220)>,
+		              <2 &shintc evt2irq(0x240)>,
+			      <3 &shintc evt2irq(0x260)>,
+		              <4 &shintc evt2irq(0x280)>,
+			      <5 &shintc evt2irq(0x2a0)>,
+		              <6 &shintc evt2irq(0x2c0)>,
+			      <7 &shintc evt2irq(0x2e0)>,
+		              <8 &shintc evt2irq(0x300)>,
+			      <9 &shintc evt2irq(0x320)>,
+		              <10 &shintc evt2irq(0x340)>,
+			      <11 &shintc evt2irq(0x360)>,
+		              <12 &shintc evt2irq(0x380)>,
+			      <13 &shintc evt2irq(0x3a0)>,
+		              <14 &shintc evt2irq(0x3c0)>;
+	};
+	pata: pata@b4001000 {
+		compatible = "ata-generic";
+		reg = <0xb4001000 0x10>, <0xb400080c 0x02>;
+		interrupt-parent = <&fpgaintc>;
+		interrupts = <1 0>;
+		reg-shift = <1>;
+		pio-mode = <0>;
+	};
+	sm501: display@13e00000 {
+		compatible = "smi,sm501";
+		reg = <0x10000000 0x13dfffff>, <0x13e00000 0x13ffffff>;
+		interrupt-parent = <&fpgaintc>;
+		interrupts = <4 0>;
+		mode = "640x480-16@60";
+		edid = [00 ff ff ff ff ff ff 00 04 21 00 00 00 00 00 00
+		        01 00 01 03 80 00 00 00 00 00 00 00 00 00 00 00
+			00 00 00 20 00 00 01 00 01 00 01 00 01 00 01 00
+			01 00 01 00 01 00 f3 0d 7b 69 30 05 23 20 00 60
+			02 00 80 e0 21 00 00 1e 00 00 00 10 00 00 00 00
+			00 00 00 00 00 00 00 00 00 00 00 00 00 10 00 00
+			00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+			00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 b7];
+		smi,devices = <1>;
+	};
+};
+
+&oclk {
+	clock-frequency = <60000000>;
+};
+
+&sci1 {
+	status = "ok";
+};
+
+&pci {
+	compatible = "renesas,sh7751-pci", "renesas.r2dplus-pci";
+	interrupt-map-mask = <0x1800 0 7>;
+	interrupt-map = <0x1000 0 1 &fpgaintc 3 0>;
+	status = "ok";
+};