Message ID | 1467188278-10978-1-git-send-email-meng.yi@nxp.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Wed, Jun 29, 2016 at 04:17:57PM +0800, Meng Yi wrote: > dropped the old "fsl,panel" property, using the of_graph dt > binding syntax > > Signed-off-by: Meng Yi <meng.yi@nxp.com> > --- > Changes in V2: > -drop the unit address of port > --- > Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Acked-by: Rob Herring <robh@kernel.org>
On 2016-06-29 01:17, Meng Yi wrote: > dropped the old "fsl,panel" property, using the of_graph dt > binding syntax > > Signed-off-by: Meng Yi <meng.yi@nxp.com> > --- > Changes in V2: > -drop the unit address of port > --- > Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt > b/Documentation/devicetree/bindings/display/fsl,dcu.txt > index ae55cde..c96ec1f 100644 > --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt > +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt > @@ -12,7 +12,7 @@ Required properties: > - clock-names: Should be "dcu" and "pix" > See ../clocks/clock-bindings.txt for details. > - big-endian Boolean property, LS1021A DCU registers are big-endian. > -- fsl,panel: The phandle to panel node. > +- port Video port for the panel output > > Optional properties: > - fsl,tcon: The phandle to the timing controller node. > @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 { > clocks = <&platform_clk 0>, <&platform_clk 0>; > clock-names = "dcu", "pix"; > big-endian; > - fsl,panel = <&panel>; > fsl,tcon = <&tcon>; > + > + port: port { Port does not need a label here. > + dcu_out: endpoint { > + remote-endpoint = <&panel_out>; > + }; > + }; > }; Otherwise looks good. However, I would prefer to have this change as part of the corresponding driver change. Can you squash that into the "drm/fsl-dcu: rework codes to support of_graph dt binding for panel" patch? -- Stefan
diff --git a/Documentation/devicetree/bindings/display/fsl,dcu.txt b/Documentation/devicetree/bindings/display/fsl,dcu.txt index ae55cde..c96ec1f 100644 --- a/Documentation/devicetree/bindings/display/fsl,dcu.txt +++ b/Documentation/devicetree/bindings/display/fsl,dcu.txt @@ -12,7 +12,7 @@ Required properties: - clock-names: Should be "dcu" and "pix" See ../clocks/clock-bindings.txt for details. - big-endian Boolean property, LS1021A DCU registers are big-endian. -- fsl,panel: The phandle to panel node. +- port Video port for the panel output Optional properties: - fsl,tcon: The phandle to the timing controller node. @@ -24,6 +24,11 @@ dcu: dcu@2ce0000 { clocks = <&platform_clk 0>, <&platform_clk 0>; clock-names = "dcu", "pix"; big-endian; - fsl,panel = <&panel>; fsl,tcon = <&tcon>; + + port: port { + dcu_out: endpoint { + remote-endpoint = <&panel_out>; + }; + }; };
dropped the old "fsl,panel" property, using the of_graph dt binding syntax Signed-off-by: Meng Yi <meng.yi@nxp.com> --- Changes in V2: -drop the unit address of port --- Documentation/devicetree/bindings/display/fsl,dcu.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)