| Message ID | 20160701211859.23471-1-sboyd@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Jul 01, 2016 at 02:18:59PM -0700, Stephen Boyd wrote: > If we fail to get the hwspinlock due to probe defer, we shouldn't > print an error message. Just be silent in this case. > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Looks good to me. This has needed to be fixed for a while. Thanks! Andy
On Fri 01 Jul 14:18 PDT 2016, Stephen Boyd wrote: > If we fail to get the hwspinlock due to probe defer, we shouldn't > print an error message. Just be silent in this case. > This generally seems to result in a large pile of drivers ending up on the probe deferr list, so something we should try to avoid. But the patch itself looks good: Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > drivers/soc/qcom/smem.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index 2e1aa9f130f4..18ec52f2078a 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev) > > hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0); > if (hwlock_id < 0) { > - dev_err(&pdev->dev, "failed to retrieve hwlock\n"); > + if (hwlock_id != -EPROBE_DEFER) > + dev_err(&pdev->dev, "failed to retrieve hwlock\n"); > return hwlock_id; > } > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c index 2e1aa9f130f4..18ec52f2078a 100644 --- a/drivers/soc/qcom/smem.c +++ b/drivers/soc/qcom/smem.c @@ -740,7 +740,8 @@ static int qcom_smem_probe(struct platform_device *pdev) hwlock_id = of_hwspin_lock_get_id(pdev->dev.of_node, 0); if (hwlock_id < 0) { - dev_err(&pdev->dev, "failed to retrieve hwlock\n"); + if (hwlock_id != -EPROBE_DEFER) + dev_err(&pdev->dev, "failed to retrieve hwlock\n"); return hwlock_id; }
If we fail to get the hwspinlock due to probe defer, we shouldn't print an error message. Just be silent in this case. Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- drivers/soc/qcom/smem.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)