| Message ID | 1467207667-15768-15-git-send-email-ysato@users.sourceforge.jp (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sato-san, On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > SH7751 core and internal peripheral define. Thanks for your patch! > Changes v4 > - remove unneeded #address-cells and #size-cells > - add missing dt-binding link Please move changelog information below the three dashes... > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > --- ... i.e. here. > --- /dev/null > +++ b/arch/sh/boot/dts/include/dt-bindings > @@ -0,0 +1 @@ > +../../../../../include/dt-bindings > \ No newline at end of file Missing newline. > --- /dev/null > +++ b/arch/sh/boot/dts/sh7751.dtsi > + oclk: oscillator { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <0>; > + }; > + cpg: cpg@ffc00000 { clock-controller@ffc00000 > \ No newline at end of file Missing newline. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 01 Jul 2016 17:57:00 +0900, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato > <ysato@users.sourceforge.jp> wrote: > > SH7751 core and internal peripheral define. > > Thanks for your patch! > > > Changes v4 > > - remove unneeded #address-cells and #size-cells > > - add missing dt-binding link > > Please move changelog information below the three dashes... > > > > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > > --- > > ... i.e. here. OK. > > --- /dev/null > > +++ b/arch/sh/boot/dts/include/dt-bindings > > @@ -0,0 +1 @@ > > +../../../../../include/dt-bindings > > \ No newline at end of file > > Missing newline. This file is symbolic link. I think not need newline. > > --- /dev/null > > +++ b/arch/sh/boot/dts/sh7751.dtsi > > > + oclk: oscillator { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <0>; > > + }; > > + cpg: cpg@ffc00000 { > > clock-controller@ffc00000 OK. > > \ No newline at end of file > > Missing newline. OK. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Sato-san, On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > --- /dev/null > +++ b/include/dt-bindings/clock/renesas-sh7750.h > @@ -0,0 +1,26 @@ > +/* > + * Copyright (C) 2016 Yoshinori Sato > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + */ > +#ifndef __DT_BINDINGS_CLOCK_RENESAS_SH7750_H__ > +#define __DT_BINDINGS_CLOCK_RENESAS_SH7750_H__ > + > +#define SH7750_CLK_SCI 0 > +#define SH7750_CLK_RTC 1 > +#define SH7750_CLK_TMU0 2 > +#define SH7750_CLK_TMU1 3 > +#define SH7750_CLK_TMU2 4 > +#define SH7750_CLK_SCIF 5 > +#define SH7750_CLK_DMAC 6 > +#define SH7750_CLK_UBC 7 > +#define SH7750_CLK_SQ 8 > +#define SH7750_CLK_INTC 9 > +#define SH7750_CLK_TMU3 10 > +#define SH7750_CLK_TMU4 11 > +#define SH7750_CLK_PCIC 12 Looking at the table in drivers/clk/sh/clk-sh7750cpg.c, SH7750_CLK_CORE seems to be missing? > + > +#endif /* __DT_BINDINGS_CLOCK_RENESAS_CPG_MSSR_H__ */ Relic from the Renesas CPG/MSSR driver. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 04 Jul 2016 16:15:31 +0900, Geert Uytterhoeven wrote: > > Hi Sato-san, > > On Wed, Jun 29, 2016 at 3:40 PM, Yoshinori Sato > <ysato@users.sourceforge.jp> wrote: > > --- /dev/null > > +++ b/include/dt-bindings/clock/renesas-sh7750.h > > @@ -0,0 +1,26 @@ > > +/* > > + * Copyright (C) 2016 Yoshinori Sato > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > + */ > > +#ifndef __DT_BINDINGS_CLOCK_RENESAS_SH7750_H__ > > +#define __DT_BINDINGS_CLOCK_RENESAS_SH7750_H__ > > + > > +#define SH7750_CLK_SCI 0 > > +#define SH7750_CLK_RTC 1 > > +#define SH7750_CLK_TMU0 2 > > +#define SH7750_CLK_TMU1 3 > > +#define SH7750_CLK_TMU2 4 > > +#define SH7750_CLK_SCIF 5 > > +#define SH7750_CLK_DMAC 6 > > +#define SH7750_CLK_UBC 7 > > +#define SH7750_CLK_SQ 8 > > +#define SH7750_CLK_INTC 9 > > +#define SH7750_CLK_TMU3 10 > > +#define SH7750_CLK_TMU4 11 > > +#define SH7750_CLK_PCIC 12 > > Looking at the table in drivers/clk/sh/clk-sh7750cpg.c, SH7750_CLK_CORE seems > to be missing? Yes. I forgot it. > > + > > +#endif /* __DT_BINDINGS_CLOCK_RENESAS_CPG_MSSR_H__ */ > > Relic from the Renesas CPG/MSSR driver. OK. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/arch/sh/boot/dts/include/dt-bindings b/arch/sh/boot/dts/include/dt-bindings new file mode 120000 index 0000000..08c00e4 --- /dev/null +++ b/arch/sh/boot/dts/include/dt-bindings @@ -0,0 +1 @@ +../../../../../include/dt-bindings \ No newline at end of file diff --git a/arch/sh/boot/dts/sh7751.dtsi b/arch/sh/boot/dts/sh7751.dtsi new file mode 100644 index 0000000..79a2ee7 --- /dev/null +++ b/arch/sh/boot/dts/sh7751.dtsi @@ -0,0 +1,83 @@ +/* + * Device Tree Source for the SH7751 + * + * Copyright (C) 2016 Yoshinori Sato + */ + +#include <dt-bindings/interrupt-controller/sh_intc.h> +#include <dt-bindings/clock/renesas-sh7750.h> + +/ { + oclk: oscillator { + #clock-cells = <0>; + compatible = "fixed-clock"; + clock-frequency = <0>; + }; + cpg: cpg@ffc00000 { + compatible = "renesas,sh7750-cpg"; + clocks = <&oclk>; + #clock-cells = <1>; + renesas,mult = <12>; + reg = <0xffc00000 32>, <0xfe0a0000 16>; + }; + cpus { + #address-cells = <1>; + #size-cells = <0>; + cpu@0 { + compatible = "renesas,sh4", "renesas,sh"; + clock-frequency = <266666666>; + }; + }; + shintc: interrupt-controller@ffd00000 { + compatible = "renesas,sh7751-intc"; + #interrupt-cells = <2>; + interrupt-controller; + reg = <0xffd00000 14>, <0xfe080000 128>; + + }; + sci0: serial@ffe00000 { + compatible = "renesas,sci"; + reg = <0xffe00000 0x20>; + interrupts = <evt2irq(0x4e0) 0>, + <evt2irq(0x500) 0>, + <evt2irq(0x540) 0>, + <evt2irq(0x520) 0>; + clocks = <&cpg SH7750_CLK_SCI>; + clock-names = "fck"; + status = "disabled"; + }; + sci1: serial@ffe80000 { + compatible = "renesas,scif"; + reg = <0xffe80000 0x100>; + interrupts = <evt2irq(0x700) 0>, + <evt2irq(0x720) 0>, + <evt2irq(0x760) 0>, + <evt2irq(0x740) 0>; + clocks = <&cpg SH7750_CLK_SCIF>; + clock-names = "fck"; + status = "disabled"; + }; + tmu: timer@ffd80000 { + compatible = "renesas,tmu"; + reg = <0xffd80000 12>; + interrupts = <evt2irq(0x400) 0>, + <evt2irq(0x420) 0>, + <evt2irq(0x440) 0>; + clocks = <&cpg SH7750_CLK_TMU0>; + clock-names = "fck"; + renesas,channels-mask = <0x03>; + }; + pci: pci-controller@fe200000 { + compatible = "renesas,sh7751-pci"; + device_type = "pci"; + bus-range = <0 0>; + #address-cells = <2>; + #size-cells = <1>; + ranges = <0x02000000 0x00000000 0xfd000000 0xfd000000 0x00000000 0x01000000>, + <0x01000000 0x00000000 0xfe240000 0x00000000 0x00000000 0x00040000>; + reg = <0xfe200000 0x0400>, <0xff800000 0x0030>; + #interrupt-cells = <1>; + interrupt-map-mask = <0x1800 0 7>; + status = "disabled"; + }; +}; \ No newline at end of file diff --git a/include/dt-bindings/clock/renesas-sh7750.h b/include/dt-bindings/clock/renesas-sh7750.h new file mode 100644 index 0000000..546c0b1 --- /dev/null +++ b/include/dt-bindings/clock/renesas-sh7750.h @@ -0,0 +1,26 @@ +/* + * Copyright (C) 2016 Yoshinori Sato + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + */ +#ifndef __DT_BINDINGS_CLOCK_RENESAS_SH7750_H__ +#define __DT_BINDINGS_CLOCK_RENESAS_SH7750_H__ + +#define SH7750_CLK_SCI 0 +#define SH7750_CLK_RTC 1 +#define SH7750_CLK_TMU0 2 +#define SH7750_CLK_TMU1 3 +#define SH7750_CLK_TMU2 4 +#define SH7750_CLK_SCIF 5 +#define SH7750_CLK_DMAC 6 +#define SH7750_CLK_UBC 7 +#define SH7750_CLK_SQ 8 +#define SH7750_CLK_INTC 9 +#define SH7750_CLK_TMU3 10 +#define SH7750_CLK_TMU4 11 +#define SH7750_CLK_PCIC 12 + +#endif /* __DT_BINDINGS_CLOCK_RENESAS_CPG_MSSR_H__ */ diff --git a/include/dt-bindings/interrupt-controller/sh_intc.h b/include/dt-bindings/interrupt-controller/sh_intc.h new file mode 100644 index 0000000..8c9dcdc --- /dev/null +++ b/include/dt-bindings/interrupt-controller/sh_intc.h @@ -0,0 +1,2 @@ +#define evt2irq(evt) (((evt) >> 5) - 16) +#define irq2evt(irq) (((irq) + 16) << 5)
SH7751 core and internal peripheral define. Changes v4 - remove unneeded #address-cells and #size-cells - add missing dt-binding link Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> --- arch/sh/boot/dts/include/dt-bindings | 1 + arch/sh/boot/dts/sh7751.dtsi | 83 ++++++++++++++++++++++ include/dt-bindings/clock/renesas-sh7750.h | 26 +++++++ include/dt-bindings/interrupt-controller/sh_intc.h | 2 + 4 files changed, 112 insertions(+) create mode 120000 arch/sh/boot/dts/include/dt-bindings create mode 100644 arch/sh/boot/dts/sh7751.dtsi create mode 100644 include/dt-bindings/clock/renesas-sh7750.h create mode 100644 include/dt-bindings/interrupt-controller/sh_intc.h