| Message ID | 1467360098-12539-11-git-send-email-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/01/2016 10:01 AM, Andi Shyti wrote: > There is no need to check in precompilation whether the ioctl is > compat or unlocked, depending on the configuration it will be > called the correct one. > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > drivers/media/rc/lirc_dev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c > index d98a9f1..16cca46 100644 > --- a/drivers/media/rc/lirc_dev.c > +++ b/drivers/media/rc/lirc_dev.c > @@ -150,9 +150,7 @@ static const struct file_operations lirc_dev_fops = { > .write = lirc_dev_fop_write, > .poll = lirc_dev_fop_poll, > .unlocked_ioctl = lirc_dev_fop_ioctl, > -#ifdef CONFIG_COMPAT > .compat_ioctl = lirc_dev_fop_ioctl, > -#endif I'd say this compat_ioctl can be dropped completely since there is nothing to do. Regards, Hans > .open = lirc_dev_fop_open, > .release = lirc_dev_fop_close, > .llseek = noop_llseek, > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index d98a9f1..16cca46 100644 --- a/drivers/media/rc/lirc_dev.c +++ b/drivers/media/rc/lirc_dev.c @@ -150,9 +150,7 @@ static const struct file_operations lirc_dev_fops = { .write = lirc_dev_fop_write, .poll = lirc_dev_fop_poll, .unlocked_ioctl = lirc_dev_fop_ioctl, -#ifdef CONFIG_COMPAT .compat_ioctl = lirc_dev_fop_ioctl, -#endif .open = lirc_dev_fop_open, .release = lirc_dev_fop_close, .llseek = noop_llseek,
There is no need to check in precompilation whether the ioctl is compat or unlocked, depending on the configuration it will be called the correct one. Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- drivers/media/rc/lirc_dev.c | 2 -- 1 file changed, 2 deletions(-)