| Message ID | 1308172355-1694-1-git-send-email-ambresh@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0b1b76515cb86064d3cdae84947e61cb7bc10b6e |
| Delegated to: | Tony Lindgren |
| Headers | show |
> -----Original Message----- > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > owner@vger.kernel.org] On Behalf Of K, Ambresh > Sent: Thursday, June 16, 2011 2:43 AM > To: Tony Lindgren > Cc: linux-omap; linux-kernel > Subject: [PATCH] OMAP4: DMTIMER: enable autoidle mode > > From: Ambresh K <ambresh@ti.com> > > Currently autoidle is only enabled for OMAP2/3; by enabling autoidle, > the automatic L4 clock gating strategy is applied based on L4 activity, > otherwise L4 clock to module will be a free running. > > Signed-off-by: Ambresh K <ambresh@ti.com> > --- > arch/arm/plat-omap/dmtimer.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c > index ee9f6eb..02d0f7a 100644 > --- a/arch/arm/plat-omap/dmtimer.c > +++ b/arch/arm/plat-omap/dmtimer.c > @@ -342,8 +342,8 @@ static void omap_dm_timer_reset(struct omap_dm_timer > *timer) > l |= 0x02 << 3; /* Set to smart-idle mode */ > l |= 0x2 << 8; /* Set clock activity to perserve f-clock on idle */ > > - /* Enable autoidle on OMAP2 / OMAP3 */ > - if (cpu_is_omap24xx() || cpu_is_omap34xx()) > + /* Enable autoidle on OMAP2 CPUs. */ > + if (cpu_class_is_omap2()) > l |= 0x1 << 0; BTW, in the hwmod adaptation series this is taken care by the framework. -- Tarun > > /* > -- > 1.6.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* K, Ambresh <ambresh@ti.com> [110615 21:41]: > On Wed, Jun 15, 2011 at 9:39 PM, DebBarma, Tarun Kanti > <tarun.kanti@ti.com>wrote: > > > > > > Currently autoidle is only enabled for OMAP2/3; by enabling autoidle, > > > the automatic L4 clock gating strategy is applied based on L4 activity, > > > otherwise L4 clock to module will be a free running. Applying this into devel-fixes. > > > - /* Enable autoidle on OMAP2 / OMAP3 */ > > > - if (cpu_is_omap24xx() || cpu_is_omap34xx()) > > > + /* Enable autoidle on OMAP2 CPUs. */ > > > + if (cpu_class_is_omap2()) > > > l |= 0x1 << 0; > > BTW, in the hwmod adaptation series this is taken care by the framework. > > > > Ok! That should be a trivial update. Let's first merge this fix so L4 can autoidle on omap4. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/plat-omap/dmtimer.c b/arch/arm/plat-omap/dmtimer.c index ee9f6eb..02d0f7a 100644 --- a/arch/arm/plat-omap/dmtimer.c +++ b/arch/arm/plat-omap/dmtimer.c @@ -342,8 +342,8 @@ static void omap_dm_timer_reset(struct omap_dm_timer *timer) l |= 0x02 << 3; /* Set to smart-idle mode */ l |= 0x2 << 8; /* Set clock activity to perserve f-clock on idle */ - /* Enable autoidle on OMAP2 / OMAP3 */ - if (cpu_is_omap24xx() || cpu_is_omap34xx()) + /* Enable autoidle on OMAP2 CPUs. */ + if (cpu_class_is_omap2()) l |= 0x1 << 0; /*