| Message ID | 577d3580.46c0620a.b8b1b.ffff9a01@mx.google.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 07/06/2016 07:44 PM, tom.ty89@gmail.com wrote: > From: Tom Yan <tom.ty89@gmail.com> > > Currently if a WRITE SAME (16) command is issued to the SATL with > "number of blocks" that is larger than the "Maximum write same length" > (which is the maximum number of blocks per TRIM command allowed in > libata, currently 65535 * 512 / 8 blocks), the SATL will accept the > command and translate it to a TRIM command with the upper limit. > > However, according to SBC (as of sbc4r11.pdf), the "device server" > should terminate the command with "Invalid field in CBD" in that case. CDB again. :-) > Signed-off-by: Tom Yan <tom.ty89@gmail.com> [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I am so sorry. Now I hate acronym. v5 coming. :-) On 7 July 2016 at 01:02, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 07/06/2016 07:44 PM, tom.ty89@gmail.com wrote: > >> From: Tom Yan <tom.ty89@gmail.com> >> >> Currently if a WRITE SAME (16) command is issued to the SATL with >> "number of blocks" that is larger than the "Maximum write same length" >> (which is the maximum number of blocks per TRIM command allowed in >> libata, currently 65535 * 512 / 8 blocks), the SATL will accept the >> command and translate it to a TRIM command with the upper limit. >> >> However, according to SBC (as of sbc4r11.pdf), the "device server" >> should terminate the command with "Invalid field in CBD" in that case. > > > CDB again. :-) > >> Signed-off-by: Tom Yan <tom.ty89@gmail.com> > > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index bfec66f..a1f061a 100644 --- a/drivers/ata/libata-scsi.c +++ b/drivers/ata/libata-scsi.c @@ -3305,7 +3305,11 @@ static unsigned int ata_scsi_write_same_xlat(struct ata_queued_cmd *qc) goto invalid_param_len; buf = page_address(sg_page(scsi_sglist(scmd))); - size = ata_set_lba_range_entries(buf, 512, block, n_block); + + if (n_block <= 65535 * 512 / 8) + size = ata_set_lba_range_entries(buf, 512, block, n_block); + else + goto invalid_fld; if (ata_ncq_enabled(dev) && ata_fpdma_dsm_supported(dev)) { /* Newer devices support queued TRIM commands */