diff mbox

ACPI/init: Correct the comments about acpi_subsystem_init

Message ID 1467602039-13186-1-git-send-email-bhe@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Baoquan He July 4, 2016, 3:13 a.m. UTC
In acpi_subsystem_init, function acpi_enable_subsystem is called to do
the real job. However with different flags passed to acpi_enable_subsystem,
different code is executed. In acpi_subsystem_init with "~ACPI_NO_ACPI_ENABLE"
passed in it will only switch over the platform to the ACPI mode. The rest
part of acpi_enable_subsystem is done when acpi_bus_init is called.

So the comments above acpi_subsystem_init is not exact, change it here.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 drivers/acpi/bus.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Rafael J. Wysocki July 6, 2016, 9:32 p.m. UTC | #1
On Monday, July 04, 2016 11:13:59 AM Baoquan He wrote:
> In acpi_subsystem_init, function acpi_enable_subsystem is called to do
> the real job. However with different flags passed to acpi_enable_subsystem,
> different code is executed. In acpi_subsystem_init with "~ACPI_NO_ACPI_ENABLE"
> passed in it will only switch over the platform to the ACPI mode. The rest
> part of acpi_enable_subsystem is done when acpi_bus_init is called.
> 
> So the comments above acpi_subsystem_init is not exact, change it here.
> 
> Signed-off-by: Baoquan He <bhe@redhat.com>

Applied, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 262ca31..eef468d 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -961,8 +961,7 @@  void __init acpi_early_init(void)
 /**
  * acpi_subsystem_init - Finalize the early initialization of ACPI.
  *
- * Switch over the platform to the ACPI mode (if possible), initialize the
- * handling of ACPI events, install the interrupt and global lock handlers.
+ * Switch over the platform to the ACPI mode (if possible).
  *
  * Doing this too early is generally unsafe, but at the same time it needs to be
  * done before all things that really depend on ACPI.  The right spot appears to