| Message ID | 1467713211-16014-1-git-send-email-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello Alim, On 07/05/2016 06:06 AM, Alim Akhtar wrote: > The s3c rtc controller on exynos7 platform uses rtc source clock > from s2mps11 pmic. This patch enables the required bits to make > rtc work on exynos7-espresso board. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- Looks good to me. Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Best regards,
On 07/05/2016 12:06 PM, Alim Akhtar wrote: > The s3c rtc controller on exynos7 platform uses rtc source clock > from s2mps11 pmic. This patch enables the required bits to make > rtc work on exynos7-espresso board. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > arch/arm64/configs/defconfig | 2 ++ > 1 file changed, 2 insertions(+) Thanks, applied, with changed commit title and message. Any more arm64 defconfig changes coming soon? Best regards, Krzysztof
On 07/06/2016 11:33 AM, Krzysztof Kozlowski wrote: > On 07/05/2016 12:06 PM, Alim Akhtar wrote: >> The s3c rtc controller on exynos7 platform uses rtc source clock >> from s2mps11 pmic. This patch enables the required bits to make >> rtc work on exynos7-espresso board. >> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> --- >> arch/arm64/configs/defconfig | 2 ++ >> 1 file changed, 2 insertions(+) > > Thanks, applied, with changed commit title and message. Any more arm64 > defconfig changes coming soon? > Thanks Krzysztof, May be we should enable CONFIG_S3C2410_WATCHDOG as well. All the bits to enable this is there, even in exynos7 dts watchdog is enabled. Let me know if you want me to send a patch or you can add in my last patch related with config changes, if this is not very difficult for you to handle. > Best regards, > Krzysztof > >
On 07/08/2016 01:29 PM, Alim Akhtar wrote: > > > On 07/06/2016 11:33 AM, Krzysztof Kozlowski wrote: >> On 07/05/2016 12:06 PM, Alim Akhtar wrote: >>> The s3c rtc controller on exynos7 platform uses rtc source clock >>> from s2mps11 pmic. This patch enables the required bits to make >>> rtc work on exynos7-espresso board. >>> >>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >>> --- >>> arch/arm64/configs/defconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> Thanks, applied, with changed commit title and message. Any more arm64 >> defconfig changes coming soon? >> > Thanks Krzysztof, > May be we should enable CONFIG_S3C2410_WATCHDOG as well. > All the bits to enable this is there, even in exynos7 dts watchdog is > enabled. > Let me know if you want me to send a patch or you can add in my last > patch related with config changes, if this is not very difficult for you > to handle. Probably there are few more things useful, like SPI, PWM etc. Need to take a closer look. Best regards, Krzysztof
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index fd2d74d..c05b8ba 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -268,6 +268,7 @@ CONFIG_RTC_DRV_EFI=y CONFIG_RTC_DRV_PL031=y CONFIG_RTC_DRV_SUN6I=y CONFIG_RTC_DRV_XGENE=y +CONFIG_RTC_DRV_S3C=y CONFIG_DMADEVICES=y CONFIG_PL330_DMA=y CONFIG_TEGRA20_APB_DMA=y @@ -282,6 +283,7 @@ CONFIG_XEN_GNTDEV=y CONFIG_XEN_GRANT_DEV_ALLOC=y CONFIG_COMMON_CLK_SCPI=y CONFIG_COMMON_CLK_CS2000_CP=y +CONFIG_COMMON_CLK_S2MPS11=y CONFIG_CLK_QORIQ=y CONFIG_COMMON_CLK_QCOM=y CONFIG_MSM_GCC_8916=y
The s3c rtc controller on exynos7 platform uses rtc source clock from s2mps11 pmic. This patch enables the required bits to make rtc work on exynos7-espresso board. Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- arch/arm64/configs/defconfig | 2 ++ 1 file changed, 2 insertions(+)