| Message ID | 1467980304-14093-3-git-send-email-andi.shyti@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 07/08/2016 02:18 PM, Andi Shyti wrote: > The samsung,exynos5433-spi has some peculiarities that bring the > need of creating a new compatible in the binding. That is not accurate. This for both: exynos5433 and exynos7. > > One of those is the 3-clocks controller management where the spi > is fed with three clocks: "spi", "busclkN" and "ioclk". > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com> > --- > Documentation/devicetree/bindings/spi/spi-samsung.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt > index 6dbdeb3..d4294c7 100644 > --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt > +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt > @@ -10,6 +10,7 @@ Required SoC Specific Properties: > - samsung,s3c6410-spi: for s3c6410 platforms > - samsung,s5pv210-spi: for s5pv210 and s5pc110 platforms > - samsung,exynos7-spi: for exynos7 platforms > + - samsung,exynos5433-spi: for exynos5433 compatible controllers As I wrote offline, proper order (alpha-numerical), so 5 before 7. > > - reg: physical base address of the controller and length of memory mapped > region. > Thanks for the patch, nice work. I see that you ignored parts of my offline comments so I guess you leave that work to others (describe required clock properties, deprecate exynos7-spi). I'll send the follow up then. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > > - reg: physical base address of the controller and length of memory mapped > > region. > > > > Thanks for the patch, nice work. I see that you ignored parts of my > offline comments so I guess you leave that work to others (describe > required clock properties, deprecate exynos7-spi). I'll send the follow > up then. I was actually doing the follow up, I think it's a different concept and therefore goes on a different patch. Andi -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 07/08/2016 02:56 PM, Andi Shyti wrote: >>> >>> - reg: physical base address of the controller and length of memory mapped >>> region. >>> >> >> Thanks for the patch, nice work. I see that you ignored parts of my >> offline comments so I guess you leave that work to others (describe >> required clock properties, deprecate exynos7-spi). I'll send the follow >> up then. > > I was actually doing the follow up, I think it's a different > concept and therefore goes on a different patch. Ah.... but the exynos5433-spi compatible is related to three clocks - you even mention it in commit message. BR, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt index 6dbdeb3..d4294c7 100644 --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt @@ -10,6 +10,7 @@ Required SoC Specific Properties: - samsung,s3c6410-spi: for s3c6410 platforms - samsung,s5pv210-spi: for s5pv210 and s5pc110 platforms - samsung,exynos7-spi: for exynos7 platforms + - samsung,exynos5433-spi: for exynos5433 compatible controllers - reg: physical base address of the controller and length of memory mapped region.
The samsung,exynos5433-spi has some peculiarities that bring the need of creating a new compatible in the binding. One of those is the 3-clocks controller management where the spi is fed with three clocks: "spi", "busclkN" and "ioclk". Signed-off-by: Andi Shyti <andi.shyti@samsung.com> --- Documentation/devicetree/bindings/spi/spi-samsung.txt | 1 + 1 file changed, 1 insertion(+)