| Message ID | 1466425022-3709-1-git-send-email-zhi.a.wang@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Jun 20, 2016 at 12:31:35PM -0000, Patchwork wrote: > == Series Details == > > Series: drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only. > URL : https://patchwork.freedesktop.org/series/8922/ > State : success > > == Summary == > > Series 8922v1 drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only. > http://patchwork.freedesktop.org/api/1.0/series/8922/revisions/1/mbox > > > fi-snb-i7-2600 total:223 pass:20 dwarn:0 dfail:0 fail:0 skip:203 I feel confident in pushing this one-liner without CI... -Chris
On ma, 2016-06-20 at 08:17 -0400, Zhi Wang wrote: > The access right of kernel param "i915.enable_gvt" should be read-only as > it only applies during module load (and is not *runtime* writable). > > Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Maybe also add, Suggested-by: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Zhi Wang <zhi.a.wang@intel.com> > --- > drivers/gpu/drm/i915/i915_params.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c > index 7effe68..8b13bfa 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -224,6 +224,6 @@ module_param_named(enable_dpcd_backlight, i915.enable_dpcd_backlight, bool, 0600 > MODULE_PARM_DESC(enable_dpcd_backlight, > "Enable support for DPCD backlight control (default:false)"); > > -module_param_named(enable_gvt, i915.enable_gvt, bool, 0600); > +module_param_named(enable_gvt, i915.enable_gvt, bool, 0400); > MODULE_PARM_DESC(enable_gvt, > "Enable support for Intel GVT-g graphics virtualization host support(default:false)");
Thanks! :P. Welcome back. On 07/12/16 18:50, Joonas Lahtinen wrote: > On ma, 2016-06-20 at 08:17 -0400, Zhi Wang wrote: >> The access right of kernel param "i915.enable_gvt" should be read-only as >> it only applies during module load (and is not *runtime* writable). >> >> Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Maybe also add, > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk> > >> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com> >> --- >> drivers/gpu/drm/i915/i915_params.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c >> index 7effe68..8b13bfa 100644 >> --- a/drivers/gpu/drm/i915/i915_params.c >> +++ b/drivers/gpu/drm/i915/i915_params.c >> @@ -224,6 +224,6 @@ module_param_named(enable_dpcd_backlight, i915.enable_dpcd_backlight, bool, 0600 >> MODULE_PARM_DESC(enable_dpcd_backlight, >> "Enable support for DPCD backlight control (default:false)"); >> >> -module_param_named(enable_gvt, i915.enable_gvt, bool, 0600); >> +module_param_named(enable_gvt, i915.enable_gvt, bool, 0400); >> MODULE_PARM_DESC(enable_gvt, >> "Enable support for Intel GVT-g graphics virtualization host support(default:false)");
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 7effe68..8b13bfa 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/i915/i915_params.c @@ -224,6 +224,6 @@ module_param_named(enable_dpcd_backlight, i915.enable_dpcd_backlight, bool, 0600 MODULE_PARM_DESC(enable_dpcd_backlight, "Enable support for DPCD backlight control (default:false)"); -module_param_named(enable_gvt, i915.enable_gvt, bool, 0600); +module_param_named(enable_gvt, i915.enable_gvt, bool, 0400); MODULE_PARM_DESC(enable_gvt, "Enable support for Intel GVT-g graphics virtualization host support(default:false)");
The access right of kernel param "i915.enable_gvt" should be read-only as it only applies during module load (and is not *runtime* writable). Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com> --- drivers/gpu/drm/i915/i915_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)