diff mbox

[5/7] gpu: drm: sti_vtg: add missing of_node_put after calling of_parse_phandle

Message ID 1467684294-20111-6-git-send-email-peter.chen@nxp.com (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Chen July 5, 2016, 2:04 a.m. UTC 
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.

Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
 drivers/gpu/drm/sti/sti_vtg.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Benjamin Gaignard July 12, 2016, 12:59 p.m. UTC | #1 
Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

2016-07-05 4:04 GMT+02:00 Peter Chen <peter.chen@nxp.com>:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>  drivers/gpu/drm/sti/sti_vtg.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index 6bf4ce4..0100c7c 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -432,6 +432,7 @@ static int vtg_probe(struct platform_device *pdev)
>         np = of_parse_phandle(pdev->dev.of_node, "st,slave", 0);
>         if (np) {
>                 vtg->slave = of_vtg_find(np);
> +               of_node_put(np);
>
>                 if (!vtg->slave)
>                         return -EPROBE_DEFER;
> --
> 1.9.1
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
index 6bf4ce4..0100c7c 100644
--- a/drivers/gpu/drm/sti/sti_vtg.c
+++ b/drivers/gpu/drm/sti/sti_vtg.c
@@ -432,6 +432,7 @@  static int vtg_probe(struct platform_device *pdev)
 	np = of_parse_phandle(pdev->dev.of_node, "st,slave", 0);
 	if (np) {
 		vtg->slave = of_vtg_find(np);
+		of_node_put(np);
 
 		if (!vtg->slave)
 			return -EPROBE_DEFER;