| Message ID | 1467748122-14833-4-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On 07/05/16 12:48, Ben Dooks wrote: > Add documentation for the AMLogic Meson RTC. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > Acked-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/rtc/rtc-amlogic.txt | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt Hi Ben, I suspect you already know this since you have Rob's ack, but you need to send bindings to Rob Herring <robh+dt@kernel.org> Mark Rutland <mark.rutland@arm.com> -Frank
On 13/07/16 06:57, Frank Rowand wrote: > On 07/05/16 12:48, Ben Dooks wrote: >> Add documentation for the AMLogic Meson RTC. >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> Acked-by: Rob Herring <robh@kernel.org> >> --- >> .../devicetree/bindings/rtc/rtc-amlogic.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt > > Hi Ben, > > I suspect you already know this since you have Rob's ack, but you need to > send bindings to > > Rob Herring <robh+dt@kernel.org> > Mark Rutland <mark.rutland@arm.com> Sorry, missed copying the email when sending. I hope he's seen them from being on the devicetree@vger.kernel.org list? I've added him as an CC: on this one to check.
On Wed, Jul 13, 2016 at 10:09:44AM +0100, Ben Dooks wrote: > On 13/07/16 06:57, Frank Rowand wrote: > > On 07/05/16 12:48, Ben Dooks wrote: > >> Add documentation for the AMLogic Meson RTC. > >> > >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > >> Acked-by: Rob Herring <robh@kernel.org> > >> --- > >> .../devicetree/bindings/rtc/rtc-amlogic.txt | 21 +++++++++++++++++++++ > >> 1 file changed, 21 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/rtc/rtc-amlogic.txt > > > > Hi Ben, > > > > I suspect you already know this since you have Rob's ack, but you need to > > send bindings to > > > > Rob Herring <robh+dt@kernel.org> > > Mark Rutland <mark.rutland@arm.com> > > Sorry, missed copying the email when sending. > > I hope he's seen them from being on the devicetree@vger.kernel.org > list? I've added him as an CC: on this one to check. From my perspective, having devicetree@vger.kernel.org alone is fine. I appreciate tastes vary across maintainers, either way is fine by me. :) You already have Rob's ack, which is sufficient, but FWIW the patch looks fine, so feel free to add mine: Acked-by: Mark Rutland <mark.rutland@arm.com> Thanks, Mark.
diff --git a/Documentation/devicetree/bindings/rtc/rtc-amlogic.txt b/Documentation/devicetree/bindings/rtc/rtc-amlogic.txt new file mode 100644 index 0000000..efc7672 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/rtc-amlogic.txt @@ -0,0 +1,21 @@ +* AMlogic Meson RTC + +Required properties: +- compatible: should be one of the following describing the hardware: + * "amlogic,meson6-rtc" + * "amlogic,meson8-rtc" + * "amlogic,meson8b-rtc" + +- reg: physical register space for the controller's memory mapped registers. + +Optional properties: +- resets: reset controller reference to allow reset of the controller +- interrupts: single interrupt reference if interrupt support needed + +Example: + + rtc: rtc@c8100740 { + compatible = "amlogic,meson6-rtc"; + reg = <0xc8100740 0x14>; + status = "disabled"; + };