| Message ID | 1467188278-10978-2-git-send-email-meng.yi@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016-06-29 01:17, Meng Yi wrote: > add of_graph dt binding for panel, and "fsl,panel" property Nit: "binding" typically describes the requirement, the specification and hence is under Documentation/devicetree/bindings/. What you add here is the dt nodes according to the bindings... Hence I would say something like Add of_graph dt nodes to describe the panel and remove the "fsl,panel" property. > is deprecated > > Signed-off-by: Meng Yi <meng.yi@nxp.com> > --- > Changes in V2: > -dropp the unit address of port > --- > arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/ls1021a-twr.dts > b/arch/arm/boot/dts/ls1021a-twr.dts > index 75ecaed..cbd92c8 100644 > --- a/arch/arm/boot/dts/ls1021a-twr.dts > +++ b/arch/arm/boot/dts/ls1021a-twr.dts > @@ -108,12 +108,22 @@ > > panel: panel { > compatible = "nec,nl4827hc19-05b"; Nit: We typically add a new line before adding a subnode. > + port { > + panel_out: endpoint { > + remote-endpoint = <&dcu_out>; > + }; > + }; > }; > }; > > &dcu { > - fsl,panel = <&panel>; > status = "okay"; > + > + port: port { Same as in bindings, port does not need a label too. > + dcu_out: endpoint { > + remote-endpoint = <&panel_out>; > + }; > + }; > }; > > &dspi1 { There is still a patch for vf-colibri-eval-v3.dtsi missing which does the same. -- Stefan
diff --git a/arch/arm/boot/dts/ls1021a-twr.dts b/arch/arm/boot/dts/ls1021a-twr.dts index 75ecaed..cbd92c8 100644 --- a/arch/arm/boot/dts/ls1021a-twr.dts +++ b/arch/arm/boot/dts/ls1021a-twr.dts @@ -108,12 +108,22 @@ panel: panel { compatible = "nec,nl4827hc19-05b"; + port { + panel_out: endpoint { + remote-endpoint = <&dcu_out>; + }; + }; }; }; &dcu { - fsl,panel = <&panel>; status = "okay"; + + port: port { + dcu_out: endpoint { + remote-endpoint = <&panel_out>; + }; + }; }; &dspi1 {
add of_graph dt binding for panel, and "fsl,panel" property is deprecated Signed-off-by: Meng Yi <meng.yi@nxp.com> --- Changes in V2: -dropp the unit address of port --- arch/arm/boot/dts/ls1021a-twr.dts | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)